Repository navigation
Handle empty groups in significance calculations - #1311
Merged
Merged
Conversation
Contributor
|
@PRIYANKA2272004 is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @ranjanasri6, your first PR on Fair Code, that's awesome, thank you. This project is about making AI more accountable, and contributions like yours are what keep that work going. We'll review your changes shortly. If you haven't already, give the contributing guide a quick read: it covers how audits are structured and what we look for in a review. And if you're finding Fair Code useful or interesting, a star on the repo genuinely helps more people find it - no pressure, just appreciated. |
yakew7
added a commit
that referenced
this pull request
Nov 11, 2026
Started in one run with check_contributors.py --stub ... --commits (snapshot moved to PR #1313, the pull request summaries filled in the stubs) and the TODO sentences replaced: the pending-closes draft note (#1310), empty groups in significance (#1311) and the configurable builder timeout (#1313). PR #1311's commit is authored by PRIYANKA2272004, who has no pull request of her own, so ranjanasri6's commit count and PRIYANKA2272004 are documented exceptions, and an identity map row is added for renuvenugopal178.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR fix?
Fixes the RuntimeWarning: Mean of empty slice that occurs when an intersectional group has no samples.
Changes made
Tests performed
python -m pytest tests/test_significance.py -q— 9 passedpython -m pytest tests/test_benchmark.py::test_empty_intersectional_cell_is_not_reported_significant -q -W error::RuntimeWarning— 1 passedCloses #1303