Repository navigation
Say which Audits job runs the slow tests, and pin it with a test - #1322
Merged
Merged
Conversation
The workflows reference described the Audits profiler/benchmark jobs only as 'conditional profiler and benchmark-harness checks', so a contributor could not learn where a slow test runs. Since yakew7#1300 the profiler job runs 'make coverage-fast' (the suite without the slow tests, with coverage) and the benchmark-harness job runs every test marked 'slow'. Spell the split out in the Audits row, and add test_workflow_reference_says_which_job_runs_the_slow_tests to tests/test_workflow_docs.py so the reference fails its own test if the description is removed again. Closes yakew7#1321.
Contributor
|
@tylrcc is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @tylrcc, your first PR on Fair Code, that's awesome, thank you. This project is about making AI more accountable, and contributions like yours are what keep that work going. We'll review your changes shortly. If you haven't already, give the contributing guide a quick read: it covers how audits are structured and what we look for in a review. And if you're finding Fair Code useful or interesting, a star on the repo genuinely helps more people find it - no pressure, just appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1321.
Docs — the Audits row in
.github/workflows/README.mdno longer says just 'conditional profiler and benchmark-harness checks'. It now states the split from #1300, verified againstaudits.yml:profilerjob runsmake coverage-fast— the suite without theslowtests, with coverage (audits.yml:137);benchmark-harnessjob runs every test markedslow—pytest tests --ignore=tests/browser -m slow(audits.yml:190), and only there.Test — new
test_workflow_reference_says_which_job_runs_the_slow_testsintests/test_workflow_docs.pyasserts the Audits row names both jobs,make coverage-fastand theslowmarker.Verification (run here):
pytest tests/test_workflow_docs.py -q→ 2 passed.