Repository navigation
Package: yeetkit from the sibling checkout, not /home/jrg - #3
Merged
Merged
Conversation
The lockfile already resolves yeetkit as ../yeetkit; package.json now says the same, so npm install works from any fresh clone that has yeetkit next to it.
necco-c
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the
yeetkitdependency at the sibling checkout (file:../yeetkit) instead offile:/home/jrg/src/yeetkit.Why
We ran cold coding agents on a fresh Debian 13 VM with the prompt "install yeet, then start up httpscope and show me it working." Every one of them hit
npm installfailing on the absolute path, then cloned yeetkit next to httpscope and rewrote the path to../yeetkitby hand.Change
package.json:"yeetkit": "file:../yeetkit".package-lock.json: the root entry says the same. The lockfile already resolvednode_modules/yeetkitto../yeetkit, so nothing changes for your layout (~/src/httpscopenext to~/src/yeetkit).npm install --package-lock-onlyleaves the lockfile untouched.Not in this PR (yeetkit)
bridge.mjsuses the globalWebSocket, which Node 20 keeps behind--experimental-websocket. ImportingWebSocketfromws, which it already depends on, would remove the need for the flag.dev.mjscallsserver.listen(port)with no host, so the dev server binds every interface. Passing"127.0.0.1"by default would stop captured traffic from being reachable over the network.createHubretries only onclose, and itserrorlistener is empty. When the first connect fails at startup, every request hangs. This is intermittent.