fix(make): build the guest ELFs the prover targets read - #918
Open
Oppen wants to merge 2 commits into
Open
Conversation
test-prover, test-prover-all, test-prover-debug, test-prover-cuda and test-disk-spill depended on compile-recursion-elfs only, so on a clean checkout every test reading executor/program_artifacts/rust/*.elf or */asm/*.elf panicked with "elf not found". test-fast additionally runs the executor suite, which reads most of the Rust guests. compile-prover-test-elfs builds the asm guests, the recursion guests, and the eight Rust guests the prover suite reads — not all 35, since the .elf rules are FORCE and would re-enter cargo per guest on every run. check-prover-test-elfs greps the prover sources and fails if one is missing from the list, so the next test to read a new guest cannot silently reintroduce the failure; it runs from lint, which CI already invokes.
The pattern matched [A-Za-z0-9_] only, so a guest directory with a hyphen would have been skipped silently. Also states what the guard does not cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The prover
maketargets now build every guest ELF the prover suite reads, and alintguard keeps that list from drifting.Why
test-prover,test-prover-all,test-prover-debug,test-prover-cudaandtest-disk-spilldepended oncompile-recursion-elfsonly. Everything else thesuite reads off disk —
executor/program_artifacts/rust/*.elf(8 guests, viastd::fs::read) andexecutor/program_artifacts/asm/*.elf(viatest_utils::run_asm_elf) — was never built, so on a clean checkout those targetspanic with
Failed to read ELF/ "run make compile-programs-rust". CI does not seeit: its jobs call
make compile-programs-rustexplicitly first.test-fastadditionally runs-p executor, whosetests/rust.rsreads ~30 of theRust guests, so it needs the full set rather than the prover subset.
How
PROVER_TEST_GUESTS— the 8 Rust guests prover tests read (allocator,commit_sum,ecsm,ef_io_demo,ethrex,hint_min,hint_multi,pure_commit) — andcompile-prover-test-elfs, which builds those plus the asmand recursion guests.
$(RUST_ARTIFACTS): the.elfrules areFORCE(cargo owns the dep graph),so depending on all 35 re-enters cargo 35 times on every local test run.
check-prover-test-elfsgrepsprover/srcandprover/testsforprogram_artifacts/rust/*.elfand fails on any name missing from the list. Itruns from
lint, which CI already invokes, and costs one grep. Without it thenext test that reads a new guest silently reintroduces the failure — which is how
this got here.
Validation
Clean checkout in a fresh worktree (no
program_artifacts/, noshared_target/):make compile-prover-test-elfs→ 8 Rust + 9 recursion + 218 asm artifacts, nothing else.make test-prover→ 557 passed, 0 failed, 24 ignored.make lint→ clean (includes the new guard).make check-prover-test-elfs PROVER_TEST_GUESTS="allocator"lists the 7 others and exits 1.
Split out of #874 review feedback; no code change, Makefile only.