Skip to content

Ensure static frameworks are embedded by default - #1628

Merged
yonaskolb merged 1 commit into
yonaskolb:masterfrom
daltonclaybrook:dalton/embed-static-frameworks
Jul 16, 2026
Merged

Ensure static frameworks are embedded by default#1628
yonaskolb merged 1 commit into
yonaskolb:masterfrom
daltonclaybrook:dalton/embed-static-frameworks

Conversation

@daltonclaybrook

Copy link
Copy Markdown
Contributor

Resolves #1627

@yonaskolb yonaskolb left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daltonclaybrook. I added that the previous behaviour happens on older declared xcode versions.

@yonaskolb
yonaskolb merged commit 4c62889 into yonaskolb:master Jul 16, 2026
3 checks passed
@marcos-strava

Copy link
Copy Markdown

Hi @daltonclaybrook and @yonaskolb this PR seems to have broken our project somehow. Our project is large and complex with dozens of xcodegen files, so it's unclear what we need to update in our xcodegen files to get this back on track.

The associated issue describes that since Xcode 15 the embed setting maybe have been happening automatically, but clearly something in our project isn't doing it 😅

Do you have some notes or suggestions of what needs to change ideally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default embed behavior for framework.static targets is incorrect

3 participants