Repository navigation
fix(ui): keep reader font labels as brand names - #438
Merged
Merged
Conversation
Arabic renders interFontName as إدخال and Welsh renders untitledSerifFontName as Serif Dideitl. The settings buttons should keep Inter and Untitled Serif in those locales.
Reader settings called t('interFontName') and t('untitledSerifFontName'),
so some locales renamed Inter and Untitled Serif. The buttons now render
those names directly. Locale JSON stays upstream-owned.
The reader font tests still named interFontName and untitledSerifFontName. Those strings are gone from code.
Dustin-Kelley
marked this pull request as ready for review
October 8, 2026 14:23
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Combine the Arabic and Welsh checks into one test and restore the previous language in try/finally.
🦋 Changeset detectedLatest commit: 2c72ff5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reader font settings translated the font names. Arabic showed إدخال for Inter. Welsh showed Serif Dideitl for Untitled Serif. Brand names stay fixed, so the buttons now render Inter and Untitled Serif directly.
What changed
interFontNameoruntitledSerifFontName.sourceSerifFontNamewas already unused in code. It remains only in locale JSON.Scope
This covers the two reader font labels. It leaves
fontLabeland the font-size and line-spacing labels translated. It leaves the locale files for the next platform-localization sync, which can dropinterFontName,untitledSerifFontName, and the already-unusedsourceSerifFontName.Tradeoffs
JSX text literals fail
i18next/no-literal-string. The names live in two constants so the lint stays on and the labels stay fixed.Blast Radius
Anyone who opens reader font settings sees Inter and Untitled Serif in every language. The generic Font label still follows the locale.
Verification
pnpm check:i18npassed with warnings.interFontNameanduntitledSerifFontNameare now orphan warnings.sourceSerifFontNamewas already an orphan. Warnings do not fail the check.pnpm lintpassed.pnpm typecheckpassed.pnpm testpassed. Core 306 tests, hooks 198, UI 522.This PR appears safe to merge; the previous testing-style issue is fixed.
What we checked:
finally. The shared setup removes rendered elements after each test.Summary
The reader’s font buttons now show Inter and Untitled Serif in every language. Other settings labels remain translated, and locale files are unchanged.
t()so translations cannot change the font names.Reviews (2) · Last reviewed commit: "fix(ui): address review feedback on font..." · Reviewed by Greptile