Skip to content

CI: move Node.js workflow to Node 20 and Actions v4 to unblock node-gyp configure - #31

Merged
yushulx merged 2 commits into
copilot/fix-ci-build-failure-95299240334from
copilot/copilotfix-node-gyp-configure-error
Aug 17, 2026
Merged

yushulx merged 2 commits into
copilot/fix-ci-build-failure-95299240334from
copilot/copilotfix-node-gyp-configure-error

Conversation

Copilot AI commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

The workflow in PR #30 fixed the C++ standard issue but then failed later at node-gyp configure because CI was still pinned to Node 16 while the test step installs global node-gyp@13 (which requires newer web globals such as ReadableStream).
This PR updates the workflow runtime and action versions so the existing build/test commands run under a compatible Node LTS.

  • Workflow runtime alignment

    • Updated both jobs in .github/workflows/main.yml from node-version: 16 to node-version: 20.
  • GitHub Actions version refresh

    • Updated both jobs from actions/checkout@v3 to actions/checkout@v4.
    • Updated both jobs from actions/setup-node@v3 to actions/setup-node@v4.
  • Command semantics preserved

    • Kept the test job command sequence unchanged (npm i node-gyp -g, npm install, node-gyp configure, node-gyp build, smoke test command).
    • Kept publish job behavior unchanged aside from runtime/action version updates.
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
  with:
    node-version: 20
    registry-url: https://registry.npmjs.org/

Co-authored-by: yushulx <2202306+yushulx@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix node-gyp configure error due to ReadableStream CI: move Node.js workflow to Node 20 and Actions v4 to unblock node-gyp configure Aug 17, 2026
Copilot AI requested a review from yushulx August 17, 2026 06:34
@yushulx
yushulx marked this pull request as ready for review August 17, 2026 06:39
@yushulx
yushulx merged commit 6ceca47 into main Aug 17, 2026
4 checks passed
@yushulx
yushulx deleted the copilot/copilotfix-node-gyp-configure-error branch August 17, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants