fix(instructions): prevent special parameter name collisions - #547
Merged
Conversation
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reusing shell-owned special parameter names
statusandpathfailure modes and recommendpurpose-specific names
deterministic regression coverage
Closes #546
Instruction impact review
machine-readable enforcement metadata.
human contributors working with enrolled Zsh source in all five execution
profiles.
.github/instructions/zsh-scripting.instructions.mdremains the prose owner;
lib/zsh-standard-policy.jsonremains the metadataowner.
scope and dynamic scope, not collisions with special parameter names.
instruction-zsh-scriptingroute already reaches the affected paths and consumers.
instruction without relying on an optional hook or skill.
private generated root composite is unaffected because neither imported
baseline policy nor the private overlay changes.
Verification
python3 -m unittest scripts/test_validate_zsh_standard_policy.py -v(99 tests passed)
python3 -m unittest scripts/test_validate_agent_policy.py -v(83 tests passed)
python3 scripts/validate-zsh-standard-policy.pypython3 scripts/validate-agent-policy.pygit diff --checkThe rule semantics were checked against the released Zsh Parameters manual and
confirmed with isolated
zsh -fprobes.