Repository navigation
refactor(skills): remove zi-install, now in agent-skills (#741) - #761
Merged
Merged
Conversation
Signed-off-by: Sal <59910950+ss-o@users.noreply.github.com>
ss-o
commented
Oct 7, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on c9b5b13
Findings
No actionable findings.
Scope: The complete diff against main (502ec61): removal of .github/skills/zi-install/SKILL.md and its surface, the inventory entry and generated resource row, and the Zi domain index link.
Note
This is a maintainer-elected self-review, not an independent review or approval to merge.
Validation
- Passed: all 12 checks on this head, including Org Routing's
verify-approvedagainst the agent-skills checkout. - Local: routing validate and verify-approved, agent policy, Zsh standard policy, knowledge delivery and coverage, and unit tests in automation/agents, knowledge, governance and ci.
Checklist verdicts and supporting evidence
- Consumers moved first: pass. z-shell/src#233 re-pinned the only vendored copy to agent-skills before this removal, and its Org Routing caller is pinned to 502ec61, whose approved record already names the agent-skills source.
- No dangling references: pass. Outside
decisions/,git grep skills/zi-installreturns only agent-skills paths; the remainingzi-installnames are the approved record and the test fixtures that model an external skill. - Generated content: pass.
knowledge-coverage.pyconfirms the resource page matches its generator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last removal step for #741:
zi-installnow lives in z-shell/agent-skills (z-shell/agent-skills#9,v0.5.0), is approved from there (#759), and its only consumer, z-shell/src, has re-pinned to it (z-shell/src#233). This PR removes the copy here..github/skills/zi-install/SKILL.mdand itsskill-zi-installinstruction surface.knowledge/domains/zi/index.md: the install task now links the skill in z-shell/agent-skills.knowledge/repository-files.json: the inventory entry is removed, andknowledge/domains/zi/repository-resources.mddrops the matching generated row.zi-installrecord inapproved-skills.json(it already names agent-skills); the z-shell/srcvendored_skillsentry; thezi-installname inorg-routingtest fixtures, which model an external skill and never read this file.Refs #741.
Verification
org-routing.py validate;verify-approved --source-root z-shell/agent-skills=<clone of main>;validate-agent-policy.py;validate-zsh-standard-policy.py;knowledge-delivery.py --check(56 consumers);knowledge-coverage.py(356 files, generated pages current): pass.git grep skills/zi-installoutsidedecisions/finds only the agent-skills path.main, andrepository-resources.mdis generated, so they stay unpadded.Agent handoff