Repository navigation
feat: expose blosc.use_threads via zarr.config #4534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sheikhayaan
wants to merge
9
commits into
zarr-developers:main
Choose a base branch
from
sheikhayaan:blosc-config-use-threads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−0
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3b4ca71
feat: expose blosc.use_threads via zarr.config
sheikhayaan 060e5c4
fix: move numcodecs import to top level and remove local imports
sheikhayaan 5f12119
fix: use noqa for local numcodecs import to avoid circular dependency
sheikhayaan b75010f
fix: resolve lint and docs build by using local blosc imports
sheikhayaan e43c0fb
fix: move numcodecs import to top level to satisfy lint
sheikhayaan 0abb755
style: apply ruff formatting
sheikhayaan ba9c4c6
fix: use importlib for lazy numcodecs import and fix formatting
sheikhayaan 2e83994
fix: use importlib and update comments
sheikhayaan b163749
fix: restore files and fix formatting perfectly
sheikhayaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Expose `blosc.use_threads` via `zarr.config`, allowing users to enable Blosc's internal threading for faster decoding of large single chunks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will behave counter-intuitively if we change the default value in numcodecs to True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @d-v-b. You're right about the default behavior. Right now, Zarr hardcodes numcodecs.blosc.use_threads = False. By exposing it in zarr.config with a default of False, we are explicitly preserving Zarr's current behavior.
If numcodecs changes its default in the future, we would just need to update the Zarr config default to match it, or users can override it via zarr.config.set({"blosc.use_threads": True}).
Since you mentioned the comprehensive thread budget design in the issue thread, should I add a note in the docs here warning that this is a temporary escape hatch until the budget system is implemented?