Repository navigation
fix: re-sync the viewer from the 1.8.3 desktop port - #6
Merged
Merged
Conversation
Sync from desktop-dev-port at b7cf55a, which merges the extension's v1.8.3 tag. viewer-dist/native/tjs moves to the runtime re-pinned to txiki.js b45ac83, and the two worker bundles are rebuilt for a refactor of the shared NUL containment helper that leaves the grid's behavior unchanged. The viewer, WebAssembly glue and query-plan library are byte-identical. The runtime follow-ups from the review of 9875455: a statement whose rows fail to convert is reset instead of left running, synchronous row conversion checks every step, vacuumInto errors carry SQLite's message (so a failed export says why instead of the generic text of the error code), and the authorizer calls uv_thread_self only for ATTACH of a named file. Inventory and notices: txiki.js 9875455 -> b45ac83. Every notice file is unchanged between them (the runtime commit touches only src/mod_sqlite3.c, tests and its CI workflow), so only the pins change. viewerSource and the README pin follow b7cf55a; the README names the extension's 1.8.3 release.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
0.3.2 on
mainwas synced from desktop-dev-port before the extension's 1.8.3 release. Its native runtime is txiki.js9875455, which the 1.8.3 cycle replaced withb45ac83after a review of the runtime, and its worker bundles predate a refactor of the shared NUL containment helper. The README and the inventory pin an unreleased port commit.Solution
Re-sync
viewer-distfrom desktop-dev-port atb7cf55a, which merges the extension'sv1.8.3tag (dbb433c), and move the pins with it.viewer-dist/native/tjs: the runtime re-pinned to txiki.jsb45ac83. Its follow-ups: a statement whose rows fail to convert is reset instead of left running, synchronous row conversion checks every step,vacuumIntoerrors carry SQLite's message instead of the generic text of the error code, and the authorizer callsuv_thread_selfonly for ATTACH of a named file.viewer-dist/worker.js,viewer-dist/native/native-worker-desktop.js: rebuilt for the shared NUL containment helper refactor; the grid's behavior is unchanged.35ac205) and the query-plan library are byte-identical tomain.Architecture
No architectural change.
scripts/sync-viewer.mjscopies the port's build outputs at a pinned commit and records their hashes inviewer-dist/manifest.json;--verifyre-checks them. It also re-checks that the native method table still matches the 38 audited methods.Per-file changes
viewer-dist/native/tjsb45ac83runtime from the port atb7cf55a.viewer-dist/worker.js,viewer-dist/native/native-worker-desktop.jsb7cf55a.viewer-dist/manifest.jsonb7cf55aand the new file hashes.third-party/inventory.json,THIRD_PARTY_NOTICES.txt9875455→b45ac83(11 occurrences each);viewerSource→b7cf55a. Every notice file is unchanged between the two runtime commits, so only the pins change.README.mdb7cf55a; the version paragraph names the extension's 1.8.3 release.Security
9875455; theb45ac83changes are error handling and statement cleanup. The runtime's contract tests passed on all five targets (zknpr/txiki.js Actions run 40086152581), and the extension's five-target native fuzz found no attached database or file write (run 40095348078).scripts/release/notices.mjs).Test plan
Run on macOS arm64.
npm test: 27/27.node scripts/release/notices.mjs: inventory and notices match the release dependency graph and viewer pin.node scripts/sync-viewer.mjs --verify: 10 files verified atb7cf55a.node scripts/release/version.mjs: 0.3.2.cargo test --lib --locked: 138 passed; the 4 ignored live tests pass with-- --ignored.v1.8.3(dbb433c) is an ancestor of the pinned port commitb7cf55a(git merge-base --is-ancestor).