lgj-abi: compile against current lance-graph main; pin test tile explicitly - #87
Merged
Merged
Conversation
…icitly lance-graph main added ExecError::ExtentOutOfRange and ExtentUnsupported (raised only by execute_extent over a partial extent). This file always executes the whole population, so both join the arms that would be a bug here. Without them lgj-abi does not compile against lance-graph main. group_sum's tiled-vs-reference test now uses an explicit 8-word tile instead of tile_words_for, so the default tile (a performance setting, 256 words after lance-graph #1281) cannot decide whether the fixture spans several tiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ac3af5ce-ce5e-4902-a277-610d55c8d51f) |
AdaWorldAPI
marked this pull request as ready for review
September 25, 2026 00:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mainadded two errors,ExecError::ExtentOutOfRangeandExecError::ExtentUnsupported, andexec_error_to_statusdid not handle them. Without the two arms,lgj-abidoes not compile against lance-graphmain. Onlyexecute_extentraises them, when called over a partial row range. This crate always runs the whole population, so reaching either would be a bug in this file. They join the existing arms of that kind.group_sum's tiled-vs-reference test now uses an explicit 8-word tile instead oftile_words_for. The default tile is a performance setting: it becomes 256 words in lance-graph #1281. The test must not depend on that default to span several tiles, and its own multi-tile assertion fails if it no longer does.This PR is independent of lance-graph #1281 and is correct against either tile default.
Verification (local, against lance-graph with #1281 applied)
cargo testinnative/lgj-abi: 191 passed.cargo clippy --all-targets -- -D warningsis clean.AllTestson JDK 28 with--enable-previewagainst the freshly built release.so: ALL PASSED (612 checks). The runtime line reported abi 0.12 andndarray::simd avx512.java-suitesCI job covers them.🤖 Generated with Claude Code
https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
Generated by Claude Code
Summary by CodeRabbit