Skip to content

lgj-abi: compile against current lance-graph main; pin test tile explicitly - #87

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/fold-distillation-pr-wave-s57uj7
Sep 25, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
claude/fold-distillation-pr-wave-s57uj7

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

What

  • Compile fix. lance-graph main added two errors, ExecError::ExtentOutOfRange and ExecError::ExtentUnsupported, and exec_error_to_status did not handle them. Without the two arms, lgj-abi does not compile against lance-graph main. Only execute_extent raises them, when called over a partial row range. This crate always runs the whole population, so reaching either would be a bug in this file. They join the existing arms of that kind.
  • Test tile pinned. group_sum's tiled-vs-reference test now uses an explicit 8-word tile instead of tile_words_for. The default tile is a performance setting: it becomes 256 words in lance-graph #1281. The test must not depend on that default to span several tiles, and its own multi-tile assertion fails if it no longer does.

This PR is independent of lance-graph #1281 and is correct against either tile default.

Verification (local, against lance-graph with #1281 applied)

  • cargo test in native/lgj-abi: 191 passed. cargo clippy --all-targets -- -D warnings is clean.
  • AllTests on JDK 28 with --enable-preview against the freshly built release .so: ALL PASSED (612 checks). The runtime line reported abi 0.12 and ndarray::simd avx512.
  • I did not run the four consumer mains locally; the java-suites CI job covers them.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG


Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Operations encountering extents that are out of range or unsupported now report an allocation failure status, consistent with related range and scratch allocation errors. This provides a more consistent error response when these conditions occur.

…icitly

lance-graph main added ExecError::ExtentOutOfRange and ExtentUnsupported
(raised only by execute_extent over a partial extent). This file always
executes the whole population, so both join the arms that would be a bug
here. Without them lgj-abi does not compile against lance-graph main.

group_sum's tiled-vs-reference test now uses an explicit 8-word tile
instead of tile_words_for, so the default tile (a performance setting,
256 words after lance-graph #1281) cannot decide whether the fixture spans
several tiles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: f1d4ad1a-24d5-4110-9911-7b26dd46b575

📥 Commits

Reviewing files that changed from the base of the PR and between c468e76 and 979692c.

📒 Files selected for processing (2)
  • native/lgj-abi/src/exports.rs
  • native/lgj-abi/src/exports/tests/group_sum.rs
 _____________________________________________________________________________________________________________________________________________________________________________________________________
< Don't think outside the box - find the box. When faced with an impossible problem, identify the real constraints. Ask yourself: 'Does it have to be done this way? Does it have to be done at all?' >
 -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 25, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_ac3af5ce-ce5e-4902-a277-610d55c8d51f)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 25, 2026 00:47
@AdaWorldAPI
AdaWorldAPI merged commit 42de5c9 into main Sep 25, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants