Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion native/lgj-abi/src/exports.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1756,7 +1756,12 @@ fn exec_error_to_status(e: ExecError) -> i32 {
| ExecError::BlendNeedsOut
| ExecError::TerminalNeedsOut { .. }
| ExecError::GateAliasesDst { .. }
| ExecError::RangeOutOfBounds { .. } => LGJ_ERR_ALLOCATION_FAILED,
| ExecError::RangeOutOfBounds { .. }
// Raised only by `execute_extent` over a PARTIAL extent. Every call in
// this file executes the whole population, so reaching either would
// be a bug here, exactly like the arms above.
| ExecError::ExtentOutOfRange { .. }
| ExecError::ExtentUnsupported { .. } => LGJ_ERR_ALLOCATION_FAILED,
}
}

Expand Down
5 changes: 4 additions & 1 deletion native/lgj-abi/src/exports/tests/group_sum.rs
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,10 @@ fn the_tiled_executor_and_the_scalar_reference_agree_on_the_lowered_program() {
for key in keys {
let program =
plan_lower::lower_group_sum(&ops, n as u32, key, LANE_VALUES as u16).unwrap();
let tile = tile_words_for(n as usize);
// An explicit narrow tile, not `tile_words_for`: the default tile
// is a performance setting (256 words since lance-graph #1281) and
// must not decide whether this fixture spans several tiles.
let tile = (n.div_ceil(64) as usize).min(8);
let need = scratch_words_for(tile, plan_lower::SLOTS as usize).unwrap();
let mut buf = vec![0u64; need];
let mut scratch = Scratch::over(&mut buf, tile, plan_lower::SLOTS as usize).unwrap();
Expand Down
Loading