Conversation
ryanraaschCDC
approved these changes
Sep 16, 2026
ryanraaschCDC
left a comment
ryanraaschCDC
left a comment
Collaborator
There was a problem hiding this comment.
looks great! Let's have Fawad review it as well since he proposed this enhancement
xop5
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
CloudClient.check_credentials()to return structured authentication results as a pandas DataFrame.The returned DataFrame includes:
The existing credential validation and logging behavior is preserved. If subscription lookup fails, the method continues to log the exception and returns an empty DataFrame with the expected columns.
Testing
test_download_job_statsdue to the test using/tmp.Fixes #281