Repository navigation
feat(templates): add app deployment template (image, compose, Helm) - #928
Open
rubenvdlinde wants to merge 3 commits into
Open
rubenvdlinde wants to merge 3 commits into
rubenvdlinde wants to merge 3 commits into
Conversation
templates/app-deploy renders, per app id, an evaluation Dockerfile (official Nextcloud 33 image with the app built from the repo and the newest stable OpenRegister release, SHA-256 checked), an entrypoint hook that syncs and enables the baked apps, a docker-compose.yml with PostgreSQL and Redis, a Helm chart over the official Nextcloud chart and an image workflow that pushes ghcr.io/conductionnl/<app> (stable: version and latest; prerelease: edge). The release workflows keep these files out of the app tarball. Assisted-by: ClaudeCode:claude-opus-5-5
The workflow-level permissions now grant contents: read only; the image job, which pushes to ghcr.io, gets packages: write. Same change as ConductionNL/openregister#10938, so a re-render keeps it. Assisted-by: ClaudeCode:claude-opus-5-5
…ped-package-write ci(templates): scope packages: write to the app-deploy image job
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
templates/app-deploy/is one set of deployment artefacts for every Conduction Nextcloud app, parameterised by the app id only.render.sh <app-id> <repo>writes into an app:Dockerfile: the officialnextcloud:33.0.10-apacheimage with the app built from the repository (same build steps and file set as the release tarball) and the newest stable OpenRegister release, checked against its published SHA-256. Prereleases are refused. Nothing secret is baked in.docker/entrypoint-hooks/before-starting/10-image-apps.sh: on every start, copies a newer baked app over the persistent copy, runsocc upgradewhen needed and enables OpenRegister, then the app.docker-compose.yml: that image with PostgreSQL and Redis, every setting documented, port bound to 127.0.0.1. When an app already has a rootdocker-compose.yml(its developer stack), the evaluation stack goes todocker/docker-compose.ymland the existing file is left alone.charts/<app>/: a chart over the official nextcloud/helm chart 9.4.1, running the same image with PostgreSQL..github/workflows/container-image.yml: builds and pushesghcr.io/conductionnl/<app>after each release. Stable: version tag andlatest. Beta and unstable:edgeonly.The release workflows now also exclude
/Dockerfile,/.dockerignoreand/chartsfrom the app tarball.Why
These are the deployment artefacts the Common Ground checker looks for (Dockerfile plus compose, a published image, a Helm chart). They are described everywhere as an evaluation image; the App Store stays the production install path.
Choices
Verified locally
docker buildok,docker compose configok,helm lint,helm templateand kubeconform (12/12 valid)./apps/planninq/and the OpenRegister API answer 200, restart is idempotent.AI disclosure: drafted with Claude Code and reviewed before submission.
🤖 Generated with Claude Code