Repository navigation
feat(stackiq): build gemma-plate-views-peers-and-definitions - #1974
rubenvdlinde merged 13 commits into
Conversation
Task 1: a GEMMA view picker on the plate. The plate lists the imported views with their release, fetches the chosen one through useViewStore with include_gebruik, draws its reference components in the view's own groups with the coverage states kept, and keeps the choice in the URL as ?view=. Coverage rows now carry the element identifier that view nodes name. Assisted-by: ClaudeCode:claude-opus-5-5
Task 4: the layer "What comparable organisations use" on the plate. When switched on it reads the peers endpoint and shows PeerUsageTable (own and peer applications per component with counts, a held-back count as fewer than 3, a heading naming the type and inhabitants band) and the peer applications of the selected component in the side panel. Assisted-by: ClaudeCode:claude-opus-5-5
Task 5: GEMMA definitions in the reference component facet. FacetService adds each element's documentation and gemmaUrl to the referenceComponent buckets from the same element lookup, and the Applications and Services pages give each value an information button whose GemmaDefinitionPopover shows the name from GEMMA, the definition and a GEMMA Online link. Assisted-by: ClaudeCode:claude-opus-5-5
Task 6: the feature doc for the GEMMA plate: the view picker, the layer of what comparable organisations use with its anonymity rule, and the GEMMA definitions in the facet. The capability rows move to built when the change is archived. Assisted-by: ClaudeCode:claude-opus-5-5
Read the view store defensively on the plate, so a plate built without its setup (as the portfolio harness test does) still computes its groups. Assisted-by: ClaudeCode:claude-opus-5-5
|
Leaving this open: it needs a product decision. Development has since merged architecture-reference-component-coverage (REQ-RCC-003), which also draws a GEMMA view on the plate and adds the component identifier. This PR conflicts with it in Generated by Claude Code |
|
Left open for a product decision: development already has "Coverage on a GEMMA view" (REQ-RCC-003, cloud-merge-stackiq Generated by Claude Code |
Development landed the coverage map (CoverageViewMap) and the component identifier while this branch added the same identifier, a view picker that groups the plate, the peers layer and the definition popover. Kept both: one componentFacts and fixture set (development's), one viewOptions (with the release label), the plate shows the peers table and the coverage map, the docs page carries both features, l10n JSON unioned and the JS bundles regenerated. cloud-merge-stackiq Assisted-by: ClaudeCode:claude-opus-5-5
Named arguments and short lines in the definition test, viewGroups split into rowsByKey and a shared groupsInOrder, the peer table's headings from one list, viewOptions refusing a non-list, and the plate specs mock the graph canvas the coverage map now brings in. cloud-merge-stackiq Assisted-by: ClaudeCode:claude-opus-5-5
… identifier The development merge auto-merged both sides' identifier into every row. cloud-merge-stackiq Assisted-by: ClaudeCode:claude-opus-5-5
|
Still open, waiting on the picker decision asked above. The branch now has development merged in (760faac) and passes the diff gates. The full suite fails the same tests as development alone, so nothing new breaks. For now the merge keeps both pickers: the peers layer and the per-view grouping at the top, plus CoverageViewMap below. Once you choose which picker stays, removing the other is a small follow-up, and then this can merge. cloud-merge-stackiq Generated by Claude Code |
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ❌ | ✅ 150/150 | |||
| npm | ✅ | ✅ 811/811 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 00:27 UTC
Download the full PDF report from the workflow artifacts.
Kept both sides of the translation additions. cloud-merge-stackiq Assisted-by: ClaudeCode:claude-opus-5-5
|
Merged development into this branch (375a899). The only conflicts were translation additions in l10n/en and l10n/nl, and both sides are kept. On the merged tree, Left open: this run could not install the composer dependencies (GitHub refused package downloads from the cloud container), so cloud-merge-stackiq Generated by Claude Code |
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ❌ | ✅ 150/150 | |||
| npm | ✅ | ✅ 811/811 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 15:19 UTC
Download the full PDF report from the workflow artifacts.
cloud-merge-stackiq Assisted-by: ClaudeCode:claude-opus-5-5
|
Merged development into this branch again ( Still left open for the one product decision asked above: which GEMMA view picker stays on the plate page, the coverage map's (REQ-RCC-003) or this PR's (REQ-GPL-001). Once that is chosen, removing the other is a small follow-up and this can merge. cloud-merge-stackiq Generated by Claude Code |
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ❌ | ✅ 150/150 | |||
| npm | ✅ | ✅ 811/811 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 18:41 UTC
Download the full PDF report from the workflow artifacts.
cloud-merge-stackiq Assisted-by: ClaudeCode:claude-opus-5-5
|
Merged development into this branch again ( cloud-merge-stackiq Generated by Claude Code |
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ❌ | ✅ 150/150 | |||
| npm | ✅ | ✅ 811/811 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 22:06 UTC
Download the full PDF report from the workflow artifacts.
…nitions cloud-merge-stackiq Assisted-by: ClaudeCode:claude-opus-5-5
|
I merged development into this branch again ( cloud-merge-stackiq Generated by Claude Code |
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ❌ | ✅ 150/150 | |||
| npm | ✅ | ✅ 811/811 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 23:40 UTC
Download the full PDF report from the workflow artifacts.
…nitions cloud-merge-stackiq Assisted-by: ClaudeCode:claude-opus-5-5
Builds the remaining code tasks of openspec/changes/gemma-plate-views-peers-and-definitions (tasks 2 and 3 landed earlier).
Tasks done
Tasks left
Tests added
Suite before/after
Generated by Claude Code