Skip to content

feat(stackiq): build gemma-plate-views-peers-and-definitions - #1974

Merged
rubenvdlinde merged 13 commits into
developmentfrom
quality/build-gemma-plate-views-peers-and-definitions
Nov 22, 2026
Merged

rubenvdlinde merged 13 commits into
developmentfrom
quality/build-gemma-plate-views-peers-and-definitions

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Builds the remaining code tasks of openspec/changes/gemma-plate-views-peers-and-definitions (tasks 2 and 3 landed earlier).

Tasks done

  • Task 1: GEMMA view picker on the plate. Lists the imported views with their release, fetches the chosen view through useViewStore with include_gebruik, draws its reference components in the view's own groups with the gap/covered/overlap states kept, and keeps the choice in the URL as ?view=. Coverage rows now carry the element identifier that view nodes name (goldens updated for the new key).
  • Task 4: the layer "What comparable organisations use": PeerUsageTable (own and peer applications per component with counts, held-back counts as "fewer than 3", heading naming the type and inhabitants band) and the peer applications of the selected component in the side panel.
  • Task 5: FacetService adds documentation and gemmaUrl to every referenceComponent bucket (from the existing element lookup); the Applications and Services pages list each reference component with an information button opening GemmaDefinitionPopover (name from GEMMA, definition, More in GEMMA Online). CnFacetSidebar shows values in a select with no slot, so the buttons sit in a list under the sidebar.
  • Task 6: docs/features/reference-component-coverage.md (view picker, comparable organisations layer, anonymity rule, definitions).

Tasks left

  • Task 4 test: the Playwright spec tests/e2e/spec-coverage/gemma-plate-peers.spec.ts is a browser test and is not written here; the vitest half is.
  • Task 6: the three capability rows move to built when the change is archived.
  • The GEMMA release in the picker shows only when the import records one on the view (release/gemmaRelease/version); the AMEF import stores none today.

Tests added

  • vitest: gemmaPlateViews.spec.js (11), peerUsageTable.spec.js (9), gemmaDefinitionPopover.spec.js (5)
  • PHPUnit: FacetServiceDefinitionTest (3)

Suite before/after

  • PHPUnit unit: 3602 OK -> 3605 OK
  • vitest: 2572 passed, 1 failed -> 2597 passed, 1 failed (the same inherited facets.spec.js FACET_DIMENSIONS failure on development)

Generated by Claude Code

Task 1: a GEMMA view picker on the plate. The plate lists the imported
views with their release, fetches the chosen one through useViewStore with
include_gebruik, draws its reference components in the view's own groups
with the coverage states kept, and keeps the choice in the URL as ?view=.
Coverage rows now carry the element identifier that view nodes name.

Assisted-by: ClaudeCode:claude-opus-5-5
Task 4: the layer "What comparable organisations use" on the plate. When
switched on it reads the peers endpoint and shows PeerUsageTable (own and
peer applications per component with counts, a held-back count as fewer
than 3, a heading naming the type and inhabitants band) and the peer
applications of the selected component in the side panel.

Assisted-by: ClaudeCode:claude-opus-5-5
Task 5: GEMMA definitions in the reference component facet. FacetService
adds each element's documentation and gemmaUrl to the referenceComponent
buckets from the same element lookup, and the Applications and Services
pages give each value an information button whose GemmaDefinitionPopover
shows the name from GEMMA, the definition and a GEMMA Online link.

Assisted-by: ClaudeCode:claude-opus-5-5
Task 6: the feature doc for the GEMMA plate: the view picker, the layer
of what comparable organisations use with its anonymity rule, and the
GEMMA definitions in the facet. The capability rows move to built when
the change is archived.

Assisted-by: ClaudeCode:claude-opus-5-5
Read the view store defensively on the plate, so a plate built without
its setup (as the portfolio harness test does) still computes its groups.

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

Leaving this open: it needs a product decision. Development has since merged architecture-reference-component-coverage (REQ-RCC-003), which also draws a GEMMA view on the plate and adds the component identifier. This PR conflicts with it in ReferenceComponentCoverageDerivation, GemmaPlate.vue, FacetedCatalogIndexView.vue, referenceComponentCoverage.js and their tests/fixtures. Question for the owner: does gemma-plate-views-peers-and-definitions still add something on top of the coverage map (peers, definitions, picking the view), and should it be rebuilt on development? Or is it superseded and should be closed? cloud-merge-stackiq


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

Left open for a product decision: development already has "Coverage on a GEMMA view" (REQ-RCC-003, CoverageViewMap with its own view picker below the plate), and this PR adds a second GEMMA view picker at the top of the same page (REQ-GPL-001, which redraws the plate per view). Merging both would put two view pickers on one GEMMA plate page. Which one is canon per the drawn board: keep RCC-003's map and drop GPL-001's picker (keeping the peers layer and definition popovers from this PR), or replace the map with this picker? The conflicts in GemmaPlate.vue, referenceComponentCoverage.js and the coverage doc follow from that choice. Tasks 2 and 3 of this change are already on development.

cloud-merge-stackiq


Generated by Claude Code

Development landed the coverage map (CoverageViewMap) and the component
identifier while this branch added the same identifier, a view picker that
groups the plate, the peers layer and the definition popover. Kept both:
one componentFacts and fixture set (development's), one viewOptions (with
the release label), the plate shows the peers table and the coverage map,
the docs page carries both features, l10n JSON unioned and the JS bundles
regenerated.

cloud-merge-stackiq

Assisted-by: ClaudeCode:claude-opus-5-5
Named arguments and short lines in the definition test, viewGroups split
into rowsByKey and a shared groupsInOrder, the peer table's headings from
one list, viewOptions refusing a non-list, and the plate specs mock the
graph canvas the coverage map now brings in.

cloud-merge-stackiq

Assisted-by: ClaudeCode:claude-opus-5-5
… identifier

The development merge auto-merged both sides' identifier into every row.

cloud-merge-stackiq

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

Still open, waiting on the picker decision asked above. The branch now has development merged in (760faac) and passes the diff gates. The full suite fails the same tests as development alone, so nothing new breaks. For now the merge keeps both pickers: the peers layer and the per-view grouping at the top, plus CoverageViewMap below. Once you choose which picker stays, removing the other is a small follow-up, and then this can merge.

cloud-merge-stackiq


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ 9ea1af4

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
composer ❌ ✅ 150/150
npm ✅ ✅ 811/811
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 00:27 UTC

Download the full PDF report from the workflow artifacts.

Kept both sides of the translation additions.

cloud-merge-stackiq

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

Merged development into this branch (375a899). The only conflicts were translation additions in l10n/en and l10n/nl, and both sides are kept. On the merged tree, npm run lint shows no errors in files this PR changes (the 21 errors are all in files from development), the five vitest specs of this PR pass (39 tests), and the l10n check passes.

Left open: this run could not install the composer dependencies (GitHub refused package downloads from the cloud container), so composer check:strict and the PHP part of the hydra diff check could not run. The PR touches lib/Service/FacetService.php, so it waits for a run that can verify the PHP side.

cloud-merge-stackiq


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ 10fa3c3

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
composer ❌ ✅ 150/150
npm ✅ ✅ 811/811
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 15:19 UTC

Download the full PDF report from the workflow artifacts.

cloud-merge-stackiq

Assisted-by: ClaudeCode:claude-opus-5-5

rubenvdlinde commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Merged development into this branch again (c0f24202), no conflicts. This run could install the PHP dependencies, so the PHP side is now checked too: the hydra diff check shows no new phpcs, phpmd, phpstan or phpunit findings in this PR's files (the two gate failures it prints, gate 59 on amef_version and gate 66 on container lookups, are in lib/ files this PR does not touch), and the PHPUnit unit suite fails the same three tests as development alone (4,408 tests).

Still left open for the one product decision asked above: which GEMMA view picker stays on the plate page, the coverage map's (REQ-RCC-003) or this PR's (REQ-GPL-001). Once that is chosen, removing the other is a small follow-up and this can merge.

cloud-merge-stackiq


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ 881279b

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
composer ❌ ✅ 150/150
npm ✅ ✅ 811/811
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 18:41 UTC

Download the full PDF report from the workflow artifacts.

cloud-merge-stackiq

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

Merged development into this branch again (9730d6b8), no conflicts. Still left open for the product decision asked above: which GEMMA view picker stays on the plate page, the coverage map's (REQ-RCC-003) or this PR's (REQ-GPL-001).

cloud-merge-stackiq


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ b2a58c7

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
composer ❌ ✅ 150/150
npm ✅ ✅ 811/811
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 22:06 UTC

Download the full PDF report from the workflow artifacts.

…nitions

cloud-merge-stackiq

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

I merged development into this branch again (53dad49b). There were no conflicts, and the merge only brings in development's openspec archive and release changes. This PR stays open until the product decision asked above is made: which GEMMA view picker stays on the plate page, the coverage map's (REQ-RCC-003) or this PR's (REQ-GPL-001).

cloud-merge-stackiq


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ 1d4cb97

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
composer ❌ ✅ 150/150
npm ✅ ✅ 811/811
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 23:40 UTC

Download the full PDF report from the workflow artifacts.

…nitions

cloud-merge-stackiq

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit b65aff1 into development Nov 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant