Repository navigation
Test the UI source against the checkout's core in CI - #306
Merged
arifBurakDemiray merged 1 commit intoOct 22, 2026
Merged
Conversation
sdk-java-ui now depends on a released core, so no build compiled or tested it against the sdk-java of the same checkout any more. It uses the core's internal classes, so a core change could break it unnoticed until the next UI release. The testUiWithLocalCore project property swaps the released core for the sdk-java project, and the cross-platform job sets it for the UI tests. Releasing a ui- tag still tests the UI against the released core it names. The property tests the UI source, not the released java-ui jar on a newer core. Also wraps the changelog line markdownlint (MD013) reported as too long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #295.
What
testUiWithLocalCoreproject property swaps the released core (ly.count.sdk:java:26.8.0) for thesdk-javaproject insdk-java-ui. The cross-platform job sets it (ORG_GRADLE_PROJECT_testUiWithLocalCore) for the UI tests on both runners.sdk-java-ui/CHANGELOG.mdline markdownlint MD013 reported (Codacy's only finding on ui separation #295).Why
With #295 the UI builds and tests only against the released core, while it uses the core's internal classes (
SDKCore,ModuleContent,ModuleFeedback,Log,WidgetAction, ...). A core change that breaks the UI source would pass CI until the next UI release. Releasing aui-tag still tests the UI against the released core it names.Verification
=false:ly.count.sdk:java:26.8.0. With-PtestUiWithLocalCore=trueorORG_GRADLE_PROJECT_testUiWithLocalCore=true:ly.count.sdk:java:26.8.0 -> project :sdk-java.:sdk-java-ui:compileTestJava -PtestUiWithLocalCore=trueand:app-javafx:compileJavapass. UI tests open JavaFX windows, so they run in CI, not locally.Not covered
The property tests the UI source on the new core, not the released java-ui jar on it. A binary compatibility check of the core's internal types the UI uses (against the last released core) would cover that; today all 49 core members the UI calls still resolve against #275's core.
🤖 Generated with Claude Code