Skip to content

Test the UI source against the checkout's core in CI #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arifBurakDemiray merged 1 commit into from
Oct 22, 2026
Merged

Test the UI source against the checkout's core in CI #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/cross-platform-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,14 @@ jobs:
#
# Deliberately without -Dcountly.ui.pageLoadTests: that enables the one class showing a
# transparent stage, which segfaults the JVM everywhere it has been tried.
#
# testUiWithLocalCore (see sdk-java-ui/build.gradle) runs the UI on this checkout's core. The
# release of a ui- tag still tests it against the released core it names.
- name: Run the JavaFX UI tests
if: always()
shell: bash
env:
ORG_GRADLE_PROJECT_testUiWithLocalCore: 'true'
run: |
if [ "$RUNNER_OS" = "Linux" ]; then
sudo apt-get update -qq && sudo apt-get install -y -qq xvfb
Expand Down
3 changes: 2 additions & 1 deletion sdk-java-ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## XX.XX.XX
* ! Minor breaking change ! `ly.count.sdk:java-ui` now has its own version numbers and is released only when it changes, so its version no longer follows the core SDK `ly.count.sdk:java`. It names the core version it needs, currently 26.8.0; if your project also declares `ly.count.sdk:java`, use that version or a newer one.
* ! Minor breaking change ! `ly.count.sdk:java-ui` now has its own version numbers and is released only when it changes, so its version no longer follows the core SDK `ly.count.sdk:java`.
It names the core version it needs, currently 26.8.0; if your project also declares `ly.count.sdk:java`, use that version or a newer one.

## 26.8.0
* First release, together with the Java SDK 26.8.0. See the Java SDK's [CHANGELOG](../CHANGELOG.md) for what it displays.
12 changes: 12 additions & 0 deletions sdk-java-ui/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,18 @@ dependencies {
testImplementation 'org.mockito:mockito-core:4.11.0'
}

// -PtestUiWithLocalCore=true builds and tests this module's source against the sdk-java project
// instead of the released core above. This module uses the core's internal classes, so a core
// change that breaks it fails CI before the core is released. It does not test the released
// java-ui jar on a newer core.
if (findProperty('testUiWithLocalCore') == 'true') {
configurations.configureEach {
resolutionStrategy.dependencySubstitution {
substitute module('ly.count.sdk:java') using project(':sdk-java')
}
}
}

// Coverage. Reports land in build/reports/jacoco/test/ (HTML to read, XML for tooling).
// "./gradlew coverage" from the repo root runs this and prints a summary.
apply plugin: 'jacoco'
Expand Down