Repository navigation
FFL-3568: Share precomputed fixtures and lossless numeric policy - #4101
leoromanovsky wants to merge 14 commits into
Conversation
Run the canonical JSON corpus through the client and persistent cache. Enforce numeric getter types, preserve legacy number reads, and automate signed fixture refreshes.
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 33c9114 | Docs | View more details | Give us feedback! |
|
🤖 Comment from Claude, working with Aaron: This PR and #4099 both change #4099 now checks whole values in Double reads as well as Int reads. We ran the shared fixtures from DataDog/ffe-system-test-data#65 against it with this PR's runner, merged with Two differences to settle:
Could you also update the description's statement that #4099 "still enforces the previous strict-type contract"? #4099 already has lossless Int reads across all numeric types. |
|
🤖 Comment from Claude, working with Aaron: P3 follow-ups after rebasing on #4099:
|
Preserve original numeric precision for typed reads and cache restoration. Ref: FFL-3568
Merge the dependency branch, pin shared fixtures to main at 9afc3f7, and address runner and numeric review feedback. Ref: FFL-3568
|
@aarsilv Follow-ups addressed in a45b99c342 and the numeric documentation follow-up:
The snapshot pins fixture main at |
Verify legacy Android accepts encrypted dependency metadata and a sibling error map while preserving otherwise valid assignments. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
Retain the current numeric converter and preserve evaluation consent when filtering unsupported fixture assignments. Document the recurring fixture update and test loop. Ref: FFL-3568
|
🤖 Comment from Codex working with Leo: Follow-up to the converter request and the fixture-runner follow-ups: 7319c496c9373de4651cd7b686f9398480e4a697 now includes current The merge retains the once-only unsupported-type warning, valid sibling flags, numeric documentation, and actionable null-targeting-key error. It also preserves evaluation consent on retained flags. The new true/false consent test fails when that propagation is removed. Local tests pass: 1,104 feature tests and 317 JVM integration tests, with three declared fixture exclusions. The release runtime suite passes all 16 tests on Android API 36 arm64, covering consent, cache restoration, retries, and disabled tracking through native and OpenFeature clients. The installed APK matches the local build. The PR description and future update template now show the fixture update, test, fix, and merge loop. They link the merged Java example and explain independent SDK adoption. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Overlapping scheduled and manual fixture updates can create duplicate draft PRs because their concurrency groups differ. A shared group per ref closes this race.
🤖 Bits Code Review · Commit 7319c49
There was a problem hiding this comment.
More details
The PR adds shared flag-evaluation fixtures, an indexed conformance runner, and automated snapshot updates while retaining develop’s numeric converter and consent propagation. This follow-up adds numeric snapshot coverage and fixes duplicate draft PR creation by serializing scheduled and manual updates; no findings remain open.
🤖 Bits Code Review · Commit 33c9114
|
Is it actually the right place for such huge fixtures verification dump? Won't RUM FIT be a better one? |
I'll investigate integrating into RUM Fit instead, thanks. |
What does this PR do?
Add 63 shared precomputed fixtures and an indexed runner for public flag evaluations, cached assignments, exposures, and evaluation events. The snapshot pins 9afc3f75c3fef9643a9c1b5e2b1e5a9adac48177. Ref: FFL-3568.
Motivation
Each SDK needs reproducible checks against the shared response contract. New fixtures must reach consumers without a coordinated SDK release.
Additional Notes
This branch merges
developand retains its numeric converter. Unsupported variation types produce a once-only warning and leave valid flags available. The merge preserves response consent on each retained flag. MissingextraLoggingdefaults remain compatible. Applicable null targeting keys produce an actionable fixture error because Android requires a string.After this PR lands, the weekly or manually triggered workflow can open one draft update PR at a time. Scheduled and manual updates share one concurrency group on
develop. The index discovers new cases without a runner list change. Each SDK adopts a pinned snapshot independently; consistency follows each consumer's tested merge. The workflow does not merge PRs or release SDKs.flowchart TD A[Add or change shared fixtures] --> B[Review and merge upstream] B --> C[Weekly or manual snapshot update] C --> D[Open one draft SDK update PR] D --> E[Run local conformance tests and SDK CI] E --> F{Tests pass?} F -->|No| G[Fix SDK or runner; correct fixtures upstream if needed] G --> E F -->|Yes| H[Review and merge SDK update] H --> AJava example: #13347 bumped the fixture revision, strengthened fixture assertions, and merged. The Android, iOS, and Flutter updates follow the same review-and-test cycle independently.
Test coverage: 1,104 feature tests and 320 JVM integration tests pass; three fixture cases have declared platform exclusions. Coverage includes numeric reads, unsupported types, cache restoration, and event matching. Snapshot tests preserve raw numeric literals before and after cache restoration. Negative controls detect lost consent and cache values replaced with zero. A deterministic concurrency simulation produces two drafts with separate event groups and one with the shared group; hosted workflow execution is not tested. Detekt reports unresolved generated classes; the local documentation gate could not run because FactoryKit is unavailable.
Runtime validation
DataDog/dd-sdk-android@33c91142be45b302e80e5197cdc019e546a5fb28Review checklist (to be filled by reviewers)