Repository navigation
FFL-3568: Define shared mobile precomputed response conformance - #65
Merged
Merged
Conversation
This was referenced Nov 3, 2026
Open
aarsilv
reviewed
Nov 4, 2026
aarsilv
reviewed
Nov 4, 2026
aarsilv
reviewed
Nov 4, 2026
aarsilv
reviewed
Nov 4, 2026
aarsilv
reviewed
Nov 4, 2026
aarsilv
reviewed
Nov 4, 2026
aarsilv
approved these changes
Nov 4, 2026
aarsilv
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Approving with some p2s and p3s love for you to consider.
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The same precomputed flag response can return different values across client SDKs. A JSON decoder can round a fractional value into an integer before a getter checks it, and a test runner can hide that defect by parsing and re-encoding the response. Fixture PRs also need to show their effect on native client tests before the fixtures reach downstream branches.
This PR defines the shared precomputed-response contract for numeric getters, flag-key obfuscation, and emitted events, and adds native compatibility previews. Ref: FFL-3568.
Changes
.gitpaths, symlink destinations, nonempty directories without valid provenance, and files outside the previous snapshot.INVALID_RESPONSEcases perform no evaluations, requirenoUnmatchedEvents: true, and cannot expect exposure or evaluation events. Correct the documentation for unsupported variation types, numeric compatibility, and duplicate-evaluation aggregation.flowchart LR P[Fixture PR: base and proposed] --> I[Import snapshots preserving response bytes] I --> S[One recorded SDK commit per platform] S --> X[iOS XCTest on macOS] S --> A[Android JVM tests] X --> R[PR comparison and native artifacts] A --> RThe preview temporarily follows
leo.romanovsky/precompute-fixture-fanoutfor iOS andleo.romanovsky/ffl-3568/precompute-fixture-fanoutfor Android. Switch these todevelopafter the canonical runners land. Flutter is validated in its downstream PR and locally; it is not a job in this preview.Consumer implementation and validation
All three consumer snapshots pin fixture commit
f2e3dc4. Validation below is local unless linked to a hosted run; it does not establish native-bridge or deployed-backend compatibility.c84ae6142efb0d73f71c6b669f4df9Shared validation: 63 fixtures validate; generated companions match; 30 fixture-tooling and 10 preview-tooling tests pass. Hosted fixture validation passes at
f2e3dc4; the mobile preview for that revision is the source for native results. Earlier preview results cover the older corpus.Decisions
Numeric reads depend on the original JSON value, regardless of the
integer,float, ornumberlabel, and retain the same behavior after cache restoration:4503599627370497.5→TYPE_MISMATCH1.20000000000000001→1.29007199254740993→TYPE_MISMATCHTYPE_MISMATCH. Signed zero is numerically zero.1e400and1e-400→TYPE_MISMATCHThere is no new global safe-integer limit for native Integer getters. Platform filters describe accessor capabilities, not implementation bugs. The precompute service retains
number; no numeric capability is added.Unsupported variation types are omitted independently and read as
FLAG_NOT_FOUND. Rejected conversions suppress exposures; evaluation events record the error. Duplicate evaluations aggregate into one event withevaluation_count: 2. Obfuscated lookup retains plaintext event identity, does not fall back to plaintext lookup, and rejects encoded responses on unsupported consumers.Consumers import generated snapshots with immutable provenance and preserve shared expectations. Merge this contract before the consumer PRs; after merge, refresh their pins to the merged revision. Unity and React Native runtime changes are outside this implementation. The downstream work and open review items above remain separate from approval of this contract.
Checklist
config/ufc-config.json— not applicable; these fixtures contain precomputed responses.evaluation-cases/— not applicable; no rules-based flags changed.