Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
61d54c4 to
b09c0de
Compare
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
b09c0de to
f892cba
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (350.29 µs) : 312, 388
. : milestone, 350,
basic (327.448 µs) : 322, 333
. : milestone, 327,
loop (8.095 ms) : 8032, 8159
. : milestone, 8095,
section candidate
noprobe (356.571 µs) : 308, 405
. : milestone, 357,
basic (327.44 µs) : 322, 333
. : milestone, 327,
loop (8.091 ms) : 8029, 8154
. : milestone, 8091,
|
f892cba to
5a2b0e1
Compare
When no scope is active, report async propagation as enabled, matching the default setting used when activating a scope without an enclosing scope. This is also consistent with capture(context), which already permits capture when there is no active scope to suppress propagation. Add a regression test checking that the query reports propagation as enabled and that a context can be captured without an active scope.
5a2b0e1 to
fa90c81
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Returning enabled without an active scope matches existing activation and capture defaults. Active-scope suppression and root-context capture guards remain intact.
🤖 Bits Code Review · Commit fa90c81
What Does This Do
Return the default async propagation setting (enabled) when no scope is active.
Motivation
Async propagation is currently reported as disabled when there's no active scope, even though
capture(context)is permitted in that state. Reporting the default also agrees with scope activation when there is no enclosing scope.Note returning enabled here does not cause unnecessary capture of work. With no active scope, the current context is the root context, which async task capture already skips before allocating task state or a continuation. Explicit
capture(root)also returns the shared root continuation rather than allocating one. Existing checks for invalid spans and explicitly disabled propagation on an active scope remain in place.