Repository navigation
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (348.691 µs) : 317, 381
. : milestone, 349,
basic (321.812 µs) : 317, 327
. : milestone, 322,
loop (7.57 ms) : 7564, 7576
. : milestone, 7570,
section candidate
noprobe (348.782 µs) : 317, 380
. : milestone, 349,
basic (322.486 µs) : 317, 328
. : milestone, 322,
loop (7.57 ms) : 7564, 7576
. : milestone, 7570,
|
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
mcculls
force-pushed
the
mcculls/cleanup-unscoped-contexts
branch
from
November 14, 2026 20:18
6f92b15 to
065a236
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
mcculls
force-pushed
the
mcculls/cleanup-unscoped-contexts
branch
from
November 15, 2026 14:21
065a236 to
3d8e54f
Compare
mcculls
force-pushed
the
mcculls/cleanup-unscoped-contexts
branch
2 times, most recently
from
November 15, 2026 21:59
b668a33 to
ffe2e21
Compare
…sure Remove the static activateSpanWithoutScope and closeActive helpers and route callers through TracerAPI. Categorize the retained instance methods as deprecated scope management supported only in legacy mode.
Save and restore test, suite, and Karate step contexts with context handles. Keep nested CI activations restorable when they end out of order, clean up vetoed Karate steps, and preserve cold-start retry instrumentation. Include context restoration, step veto, and cold-start retry regressions.
Restore AWS SDK v1 request contexts at execution exit and keep SDK v2 legacy scope advice separate from context restoration advice. Preserve async signing contexts and retain the legacy scope lifecycle. Include request restoration, async signing, missing-context, and legacy client regressions.
Use MongoPendingSpan to hand command spans from connection advice to the command listener without changing the active context. Create a command span when no pending span is available and inject the helper into all supported driver instrumentation modules. Include helper and async DBM handoff regressions for both context managers, with the corresponding test suite configuration and dependency locks.
Keep ScopeManager.active().close() as an active-span view in non-legacy mode and warn once that callers must close the scope returned by activate. Preserve legacy closure and strict-mode checks across both instrumented OpenTracing versions and the compatibility library. Include active-view closure regressions for all three implementations.
mcculls
force-pushed
the
mcculls/cleanup-unscoped-contexts
branch
from
November 16, 2026 23:56
ffe2e21 to
f3d5901
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Restore the previous context after CI Visibility, Karate, and AWS operations when using the non-legacy context manager. Hand Mongo command spans to the command listener without activating them, and warn once when OpenTracing callers attempt to close an active-span view instead of the scope returned by activation.
Motivation
These paths relied on legacy scope activation and closure semantics. Use explicit context restoration for the non-legacy manager while preserving the legacy paths, and remove the static
AgentTracerhelpers that made those scope operations easy to reuse.Additional Notes
Regression coverage includes nested and out-of-order CI activations, vetoed Karate steps and cold-start retries, AWS request and async-signing restoration, Mongo pending-span handoff, and OpenTracing active-view closure.
Versioned Karate suites and their forked tests share the same minimum JVM constraints: Java 11 for Karate 1.4.1 and Java 17 for the latest 1.x release. This prevents Java 8 CI from trying to load incompatible Karate classes.
Validated locally: both suites and their forked tasks skip Java 8; Karate 1.4.1's normal and forked tests pass on Java 11; latest Karate's normal and forked tests pass on Java 17. The JVM constraint check and module formatting also pass.