Skip to content

Remove leftover Lettuce reactive scope tracking - #13455

Draft
mcculls wants to merge 1 commit into
mcculls/cleanup-unscoped-contextsfrom
mcculls/remove-unused-lettuce-scope-tracking
Draft

mcculls wants to merge 1 commit into
mcculls/cleanup-unscoped-contextsfrom
mcculls/remove-unused-lettuce-scope-tracking

Conversation

@mcculls

@mcculls mcculls commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Remove unused Lettuce reactive advice and flow tracking, along with the stale type match, documentation, and parent-span scope state.

Motivation

PR #7644 removed the createMono and create*Flux advice registrations and stopped injecting LettuceFlowTracker, leaving this code unused. This completes that cleanup, including the discarded scope in the unreachable flow tracker.

@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring inst: lettuce Lettuce instrumentation tag: ai generated Largely based on code generated by an AI or LLM labels Nov 13, 2026
@mcculls
mcculls added this pull request to stack #13397 November 13, 2026 22:47
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 40.38% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 717aad2 | Docs | Give us feedback!

@pr-commenter

pr-commenter Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1794780495 1794780836
end_time 2026-11-15T22:09:46 2026-11-15T22:15:27
git_branch master mcculls/remove-unused-lettuce-scope-tracking
git_commit_sha e8e4235 4d295c8
start_time 2026-11-15T22:08:16 2026-11-15T22:13:57
See matching parameters
Baseline Candidate
ci_job_id 2255929723 2255929723
ci_pipeline_id 153369332 153369332
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1794779748 1794779748

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-1.458ms; -1.173ms] or [-16.476%; -13.260%]
better
[-1.485ms; -1.200ms] or [-16.618%; -13.429%]
better
[-1.484ms; -1.197ms] or [-16.520%; -13.323%]
better
[-1.466ms; -1.158ms] or [-16.162%; -12.767%]
better
[+14.948op/s; +19.653op/s] or [+13.378%; +17.589%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-23.554µs; +51.150µs] or [-7.002%; +15.206%]
unstable
[-28.286µs; +64.670µs] or [-7.714%; +17.637%]
unstable
[-35.523µs; +77.613µs] or [-9.345%; +20.417%]
unstable
[-77.959µs; +543.631µs] or [-7.342%; +51.200%]
same
scenario:basic same same same unstable
[-132.349µs; +280.001µs] or [-13.986%; +29.590%]
unstable
[-132.833op/s; +132.833op/s] or [-5.977%; +5.977%]
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (366.673 µs) : 344, 389
.   : milestone, 367,
basic (348.407 µs) : 341, 356
.   : milestone, 348,
loop (8.938 ms) : 8751, 9125
.   : milestone, 8938,
section candidate
noprobe (384.865 µs) : 327, 443
.   : milestone, 385,
basic (343.874 µs) : 339, 349
.   : milestone, 344,
loop (7.595 ms) : 7587, 7604
.   : milestone, 7595,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 366.673 µs [344.3 µs, 389.046 µs]
basic 348.407 µs [340.718 µs, 356.097 µs]
loop 8.938 ms [8.751 ms, 9.125 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 384.865 µs [326.609 µs, 443.121 µs]
basic 343.874 µs [338.698 µs, 349.051 µs]
loop 7.595 ms [7.587 ms, 7.604 ms]

@dd-octo-sts

dd-octo-sts Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.97 s [-0.4%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.91 s 13.01 s [-1.6%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 17.24 s 17.11 s [-0.4%; +2.0%] (no difference)
startup:petclinic:iast:Agent 16.98 s 17.16 s [-1.9%; -0.2%] (maybe better)
startup:petclinic:profiling:Agent 16.78 s 16.88 s [-1.6%; +0.4%] (no difference)
startup:petclinic:sca:Agent 17.17 s 16.90 s [+0.7%; +2.5%] (maybe worse)
startup:petclinic:tracing:Agent 16.22 s 16.41 s [-2.1%; -0.2%] (maybe better)

Commit: 4d295c8f · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@pr-commenter

pr-commenter Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch mcculls/cleanup-unscoped-contexts mcculls/remove-unused-lettuce-scope-tracking
git_commit_sha ffe2e21 4d295c8
See matching parameters
Baseline Candidate
ci_job_date 1794780998 1794780998
ci_job_id 2255929714 2255929714
ci_pipeline_id 153369332 153369332
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1794779748 1794779748
jdkVersion 11.0.31 11.0.31
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dhttp.proxyHost=127.0.0.1 -Dhttp.proxyPort=15002 -Dhttps.proxyHost=127.0.0.1 -Dhttps.proxyPort=15002 -Dhttp.nonProxyHosts=localhost *.localhost
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-7t65bimb 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-7t65bimb 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.31+11-post-1ubuntu1-22.04.2-Ubuntu 11.0.31+11-post-1ubuntu1-22.04.2-Ubuntu

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@mcculls
mcculls force-pushed the mcculls/remove-unused-lettuce-scope-tracking branch from 0a63724 to c20424e Compare November 14, 2026 20:18
@pr-commenter

pr-commenter Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch mcculls/cleanup-unscoped-contexts mcculls/remove-unused-lettuce-scope-tracking
git_commit_sha ffe2e21 4d295c8
See matching parameters
Baseline Candidate
ci_job_date 1794781009 1794781009
ci_job_id 2255929718 2255929718
ci_pipeline_id 153369332 153369332
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1794779748 1794779748
jdkVersion 11.0.31 11.0.31
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dhttp.proxyHost=127.0.0.1 -Dhttp.proxyPort=15002 -Dhttps.proxyHost=127.0.0.1 -Dhttps.proxyPort=15002 -Dhttp.nonProxyHosts=localhost *.localhost
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-7a3g7ta6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-7a3g7ta6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.31+11-post-1ubuntu1-22.04.2-Ubuntu 11.0.31+11-post-1ubuntu1-22.04.2-Ubuntu

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario Δ mean throughput
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume worse
[-9385.205op/s; -2415.677op/s] or [-4.996%; -1.286%]
See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume unsure
[-12961.256op/s; -112.702op/s] or [-4.199%; -0.037%]

@mcculls
mcculls force-pushed the mcculls/remove-unused-lettuce-scope-tracking branch from c20424e to a55040b Compare November 15, 2026 14:21
@mcculls
mcculls force-pushed the mcculls/remove-unused-lettuce-scope-tracking branch from a55040b to f719fd1 Compare November 15, 2026 21:01
@mcculls
mcculls force-pushed the mcculls/remove-unused-lettuce-scope-tracking branch from f719fd1 to 4d295c8 Compare November 15, 2026 21:59
Commit e10da91 removed the createMono and create*Flux advice registrations and stopped injecting LettuceFlowTracker, leaving the implementation unused.

Remove the unused advice classes and flow tracker, the stale AbstractRedisReactiveCommands match and documentation, and the never-assigned parent-span field and its redundant scope handling.
@mcculls
mcculls force-pushed the mcculls/remove-unused-lettuce-scope-tracking branch from 4d295c8 to 717aad2 Compare November 16, 2026 23:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: lettuce Lettuce instrumentation tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant