Repository navigation
Assert the missing targeting key error code - #75
Open
leoromanovsky wants to merge 1 commit into
Open
leoromanovsky wants to merge 1 commit into
leoromanovsky wants to merge 1 commit into
Conversation
sameerank
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The null-targeting-key case for
new-user-onboardingexpects an error and the caller default but leaves its error code unchecked. A consumer can therefore report the wrong cause and still pass the shared fixture.Changes
Expect
TARGETING_KEY_MISSINGwhen this flag needs a targeting key for split assignment and receivesnull. The default value andERRORreason remain the same. This completes an existing expectation without changing the flag configuration.Decisions
The Java canonical runner confirms this result, and changing the expected code to
FLAG_NOT_FOUNDmakes that case fail. Native validation used Java PR #13347, its runner follow-up at81484981f698acc9c506676dd5291eeb07fcf726, and fixture revision6df74e605f7c1eed8b397dc9aa4c002691475939plus this one-line correction. The case and flag configuration relevant to it are unchanged on this PR's base. The full Java module suite passed 1,374 tests; this does not establish compatibility for other SDKs. Static fixture validation on this PR passes for 453 cases across 60 files and three suites.Merge this upstream correction before advancing downstream fixture pins.
Checklist
config/ufc-config.json(no new cases; existing flag remains in rootufc-config.json)evaluation-cases/(no new flags)