Skip to content

Assert the missing targeting key error code - #75

Open
leoromanovsky wants to merge 1 commit into
mainfrom
codex/null-targeting-key-error-code
Open

leoromanovsky wants to merge 1 commit into
mainfrom
codex/null-targeting-key-error-code

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

The null-targeting-key case for new-user-onboarding expects an error and the caller default but leaves its error code unchecked. A consumer can therefore report the wrong cause and still pass the shared fixture.

Changes

Expect TARGETING_KEY_MISSING when this flag needs a targeting key for split assignment and receives null. The default value and ERROR reason remain the same. This completes an existing expectation without changing the flag configuration.

Decisions

The Java canonical runner confirms this result, and changing the expected code to FLAG_NOT_FOUND makes that case fail. Native validation used Java PR #13347, its runner follow-up at 81484981f698acc9c506676dd5291eeb07fcf726, and fixture revision 6df74e605f7c1eed8b397dc9aa4c002691475939 plus this one-line correction. The case and flag configuration relevant to it are unchanged on this PR's base. The full Java module suite passed 1,374 tests; this does not establish compatibility for other SDKs. Static fixture validation on this PR passes for 453 cases across 60 files and three suites.

Merge this upstream correction before advancing downstream fixture pins.

Checklist

  • JSON files are valid (no syntax errors)
  • New test cases reference existing flags in config/ufc-config.json (no new cases; existing flag remains in root ufc-config.json)
  • New flags have corresponding test cases in evaluation-cases/ (no new flags)
  • Expected results match the flag configuration logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants