Repository navigation
chore(deps): bump dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from 8c4d241 to 6df74e6 - #13347
Conversation
…ystem-test-data Bumps [dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `8c4d241` to `6df74e6`. - [Commits](DataDog/ffe-system-test-data@8c4d241...6df74e6) --- updated-dependencies: - dependency-name: dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data dependency-version: 6df74e605f7c1eed8b397dc9aa4c002691475939 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Compatibility of the updated fixture revision with the Java smoke tests remains unverified because the specialist could not access the submodule contents. The pointer update and local consumers yielded no actionable finding.
🤖 Bits Code Review · Commit 5ce4f3f
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
leoromanovsky
left a comment
There was a problem hiding this comment.
🤖 Comment from Codex working with leoromanovsky:
Requesting changes while we strengthen the shared-fixture assertions. The current canonical runner does not check result.features, so these fixtures do not verify their expected hook, exposure, and evaluation feature maps. This gap predates this fixture bump.
We are preparing exact comparisons for all three destination maps, including empty maps, plus checks that reject unhandled expectation fields. We are also adding the missing error-code expectation to the shared null-targeting-key case. The changes are being prepared locally; we will run the full dd-openfeature suite and verify that deliberately incorrect expectations fail, then address any behavior those checks expose.
Evidence for the assertion gap
At 5ce4f3f9f998bbcc15aef9fbfd12ca97d4a398f0, changing one expected feature value in each of HOOK, EXPOSURE, and EVALUATION still left all 440 canonical tests passing. Separate routing unit tests exist; the gap is in consuming the shared fixtures' expected maps through the canonical parser/evaluator path.
See the canonical runner assertions and the shared feature expectations.
leoromanovsky
left a comment
There was a problem hiding this comment.
🤖 Comment from Codex working with leoromanovsky:
Approved at 81484981f698acc9c506676dd5291eeb07fcf726. The canonical runner now checks complete feature maps for all three destinations and rejects unhandled expectation fields. All 1,374 dd-openfeature unit tests and the Java formatting check pass locally. Deliberately incorrect feature-map expectations fail as intended.
The missing TARGETING_KEY_MISSING expectation is published separately in ffe-system-test-data #75. Java keeps this PR's existing fixture pin until that upstream correction merges. Local checks do not establish CI completion.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
07bc122
into
master
Bumps dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from
8c4d241to6df74e6.Commits
6df74e6test(ffe): clarify property is an unknown reference keyfdd48adtest(ffe): cover unknown flagEvaluation fieldsb57eac6Extract shared response signing conformance fixtures (#64)de76919Generate protobuf and offline wire artifacts from canonical UFC fixtures (#47)3d529a0Document fixture consumer mechanisms (#44)6a10771feat: serial-id-on-exposure precomputed assignment fixture (#36)c8cc8datest: cover unassigned prerequisite failure (#60)d8911fdSkip large integer precision fixture on Android (#42)33f2f84[FFL-1795] Assert rejected dependency exposure suppression (#58)1ae3edafeat: add evaluation case applicability controls (#56)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)