Skip to content

chore(deps): bump dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from 8c4d241 to 6df74e6 - #13347

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
dependabot/submodules/dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data-6df74e6
Nov 12, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
dependabot/submodules/dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data-6df74e6

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Bumps dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from 8c4d241 to 6df74e6.

Commits
  • 6df74e6 test(ffe): clarify property is an unknown reference key
  • fdd48ad test(ffe): cover unknown flagEvaluation fields
  • b57eac6 Extract shared response signing conformance fixtures (#64)
  • de76919 Generate protobuf and offline wire artifacts from canonical UFC fixtures (#47)
  • 3d529a0 Document fixture consumer mechanisms (#44)
  • 6a10771 feat: serial-id-on-exposure precomputed assignment fixture (#36)
  • c8cc8da test: cover unassigned prerequisite failure (#60)
  • d8911fd Skip large integer precision fixture on Android (#42)
  • 33f2f84 [FFL-1795] Assert rejected dependency exposure suppression (#58)
  • 1ae3eda feat: add evaluation case applicability controls (#56)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

…ystem-test-data

Bumps [dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `8c4d241` to `6df74e6`.
- [Commits](DataDog/ffe-system-test-data@8c4d241...6df74e6)

---
updated-dependencies:
- dependency-name: dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data
  dependency-version: 6df74e605f7c1eed8b397dc9aa4c002691475939
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested review from a team as code owners November 10, 2026 17:24
@dependabot dependabot Bot added the comp: openfeature OpenFeature label Nov 10, 2026
@dependabot
dependabot Bot requested review from PerfectSlayer and removed request for a team November 10, 2026 17:24
@dependabot dependabot Bot added tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes labels Nov 10, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T17:27:28.142364Z 5ce4f3f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Compatibility of the updated fixture revision with the Java smoke tests remains unverified because the specialist could not access the submodule contents. The pointer update and local consumers yielded no actionable finding.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 5ce4f3f

@dd-octo-sts

dd-octo-sts Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 13.91 s [+0.0%; +1.5%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.89 s 13.03 s [-2.0%; -0.3%] (maybe better)
startup:petclinic:appsec:Agent 17.80 s 17.69 s [-0.2%; +1.5%] (no difference)
startup:petclinic:iast:Agent 17.70 s 17.74 s [-1.3%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 17.54 s 17.31 s [+0.2%; +2.4%] (maybe worse)
startup:petclinic:sca:Agent 17.85 s 17.74 s [-0.3%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 16.34 s 16.77 s [-7.0%; +1.8%] (no difference)

Commit: 81484981 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@leoromanovsky leoromanovsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Comment from Codex working with leoromanovsky:

Requesting changes while we strengthen the shared-fixture assertions. The current canonical runner does not check result.features, so these fixtures do not verify their expected hook, exposure, and evaluation feature maps. This gap predates this fixture bump.

We are preparing exact comparisons for all three destination maps, including empty maps, plus checks that reject unhandled expectation fields. We are also adding the missing error-code expectation to the shared null-targeting-key case. The changes are being prepared locally; we will run the full dd-openfeature suite and verify that deliberately incorrect expectations fail, then address any behavior those checks expose.

Evidence for the assertion gap

At 5ce4f3f9f998bbcc15aef9fbfd12ca97d4a398f0, changing one expected feature value in each of HOOK, EXPOSURE, and EVALUATION still left all 440 canonical tests passing. Separate routing unit tests exist; the gap is in consuming the shared fixtures' expected maps through the canonical parser/evaluator path.

See the canonical runner assertions and the shared feature expectations.

@leoromanovsky leoromanovsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Comment from Codex working with leoromanovsky:

Approved at 81484981f698acc9c506676dd5291eeb07fcf726. The canonical runner now checks complete feature maps for all three destinations and rejects unhandled expectation fields. All 1,374 dd-openfeature unit tests and the Java formatting check pass locally. Deliberately incorrect feature-map expectations fail as intended.

The missing TARGETING_KEY_MISSING expectation is published separately in ffe-system-test-data #75. Java keeps this PR's existing fixture pin until that upstream correction merges. Local checks do not establish CI completion.

@datadog-official

datadog-official Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.68% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8148498 | Docs | Give us feedback!

@leoromanovsky
leoromanovsky added this pull request to the merge queue Nov 12, 2026
@dd-octo-sts

dd-octo-sts Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-11-12 20:22:56 UTC ℹ️ Start processing command /merge


2026-11-12 20:23:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-11-12 21:06:21 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 12, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 07bc122 into master Nov 12, 2026
692 of 696 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the dependabot/submodules/dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data-6df74e6 branch November 12, 2026 21:06
@github-actions github-actions Bot added this to the 1.69.0 milestone Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature tag: ai generated Largely based on code generated by an AI or LLM tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant