Repository navigation
fix(ffe): require explicit allocation doLog values - #2705
leoromanovsky wants to merge 1 commit into
Conversation
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results📦
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 096a3cc | Docs | View more details | Give us feedback! |
BenchmarksComparisonBenchmark execution time: 2026-10-20 20:10:28 Comparing candidate commit 096a3cc in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 10 metrics, 0 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | 096a3cc | 1792526314 | leoromanovsky/dolog-required |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| flagevaluation_evp/payloads/scale/2500flags_500users_20fields | execution_time | 34.661ms | 35.072ms ± 0.141ms | 35.092ms ± 0.088ms | 35.170ms | 35.274ms | 35.380ms | 35.465ms | 1.06% | -0.345 | 0.200 | 0.40% | 0.010ms | 1 | 200 |
| flagevaluation_evp/payloads/scale/2500flags_500users_20fields | throughput | 70492.998op/s | 71283.416op/s ± 287.347op/s | 71240.499op/s ± 177.951op/s | 71465.939op/s | 71817.254op/s | 72034.862op/s | 72127.287op/s | 1.24% | 0.370 | 0.214 | 0.40% | 20.319op/s | 1 | 200 |
| flagevaluation_evp/payloads/stress/10flags_1000users_250fields | execution_time | 193.451ms | 194.562ms ± 0.427ms | 194.547ms ± 0.230ms | 194.777ms | 195.105ms | 195.584ms | 197.904ms | 1.73% | 2.448 | 17.885 | 0.22% | 0.030ms | 1 | 200 |
| flagevaluation_evp/payloads/stress/10flags_1000users_250fields | throughput | 5052.966op/s | 5139.783op/s ± 11.227op/s | 5140.148op/s ± 6.067op/s | 5146.127op/s | 5155.516op/s | 5159.903op/s | 5169.263op/s | 0.57% | -2.358 | 17.066 | 0.22% | 0.794op/s | 1 | 200 |
| flagevaluation_evp/payloads/typical/100flags_50users_10fields | execution_time | 842.872µs | 844.718µs ± 0.665µs | 844.699µs ± 0.391µs | 845.100µs | 845.869µs | 846.514µs | 848.093µs | 0.40% | 0.826 | 3.135 | 0.08% | 0.047µs | 1 | 200 |
| flagevaluation_evp/payloads/typical/100flags_50users_10fields | throughput | 117911.551op/s | 118382.721op/s ± 93.109op/s | 118385.429op/s ± 54.816op/s | 118438.896op/s | 118515.335op/s | 118581.002op/s | 118642.019op/s | 0.22% | -0.815 | 3.096 | 0.08% | 6.584op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| flagevaluation_evp/payloads/scale/2500flags_500users_20fields | execution_time | [35.052ms; 35.091ms] or [-0.056%; +0.056%] | None | None | None |
| flagevaluation_evp/payloads/scale/2500flags_500users_20fields | throughput | [71243.593op/s; 71323.240op/s] or [-0.056%; +0.056%] | None | None | None |
| flagevaluation_evp/payloads/stress/10flags_1000users_250fields | execution_time | [194.502ms; 194.621ms] or [-0.030%; +0.030%] | None | None | None |
| flagevaluation_evp/payloads/stress/10flags_1000users_250fields | throughput | [5138.227op/s; 5141.339op/s] or [-0.030%; +0.030%] | None | None | None |
| flagevaluation_evp/payloads/typical/100flags_50users_10fields | execution_time | [844.626µs; 844.811µs] or [-0.011%; +0.011%] | None | None | None |
| flagevaluation_evp/payloads/typical/100flags_50users_10fields | throughput | [118369.817op/s; 118395.626op/s] or [-0.011%; +0.011%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | 096a3cc | 1792526314 | leoromanovsky/dolog-required |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 261.661µs | 269.176µs ± 12.757µs | 264.944µs ± 1.454µs | 268.550µs | 286.258µs | 310.903µs | 391.412µs | 47.73% | 5.750 | 45.334 | 4.73% | 0.902µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [267.408µs; 270.944µs] or [-0.657%; +0.657%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | 096a3cc | 1792526314 | leoromanovsky/dolog-required |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 156.630ns | 160.699ns ± 2.880ns | 160.234ns ± 1.438ns | 161.718ns | 165.224ns | 168.958ns | 179.666ns | 12.13% | 2.347 | 10.403 | 1.79% | 0.204ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [160.300ns; 161.098ns] or [-0.248%; +0.248%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | 096a3cc | 1792526314 | leoromanovsky/dolog-required |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| flagevaluation_evp/coalescer/scale/2500flags_500users_20fields | execution_time | 31.551ms | 31.712ms ± 0.075ms | 31.721ms ± 0.052ms | 31.758ms | 31.825ms | 31.928ms | 31.949ms | 0.72% | 0.276 | 0.235 | 0.24% | 0.005ms | 1 | 200 |
| flagevaluation_evp/coalescer/scale/2500flags_500users_20fields | throughput | 78248.601op/s | 78835.633op/s ± 186.038op/s | 78811.592op/s ± 127.981op/s | 78977.312op/s | 79122.574op/s | 79216.484op/s | 79236.013op/s | 0.54% | -0.261 | 0.210 | 0.24% | 13.155op/s | 1 | 200 |
| flagevaluation_evp/coalescer/stress/10flags_1000users_250fields | execution_time | 201.272ms | 202.269ms ± 1.423ms | 201.855ms ± 0.185ms | 202.056ms | 206.976ms | 207.452ms | 207.530ms | 2.81% | 3.049 | 7.759 | 0.70% | 0.101ms | 1 | 200 |
| flagevaluation_evp/coalescer/stress/10flags_1000users_250fields | throughput | 4818.576op/s | 4944.143op/s ± 34.059op/s | 4954.054op/s ± 4.539op/s | 4958.050op/s | 4962.325op/s | 4965.800op/s | 4968.389op/s | 0.29% | -3.039 | 7.716 | 0.69% | 2.408op/s | 1 | 200 |
| flagevaluation_evp/coalescer/typical/100flags_50users_10fields | execution_time | 695.461µs | 697.394µs ± 1.110µs | 697.377µs ± 0.466µs | 697.802µs | 698.417µs | 698.792µs | 709.884µs | 1.79% | 7.062 | 78.217 | 0.16% | 0.079µs | 1 | 200 |
| flagevaluation_evp/coalescer/typical/100flags_50users_10fields | throughput | 140868.102op/s | 143391.284op/s ± 225.801op/s | 143394.421op/s ± 95.874op/s | 143499.885op/s | 143629.231op/s | 143761.164op/s | 143789.557op/s | 0.28% | -6.919 | 76.138 | 0.16% | 15.967op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| flagevaluation_evp/coalescer/scale/2500flags_500users_20fields | execution_time | [31.701ms; 31.722ms] or [-0.033%; +0.033%] | None | None | None |
| flagevaluation_evp/coalescer/scale/2500flags_500users_20fields | throughput | [78809.850op/s; 78861.417op/s] or [-0.033%; +0.033%] | None | None | None |
| flagevaluation_evp/coalescer/stress/10flags_1000users_250fields | execution_time | [202.072ms; 202.467ms] or [-0.098%; +0.098%] | None | None | None |
| flagevaluation_evp/coalescer/stress/10flags_1000users_250fields | throughput | [4939.422op/s; 4948.863op/s] or [-0.095%; +0.095%] | None | None | None |
| flagevaluation_evp/coalescer/typical/100flags_50users_10fields | execution_time | [697.240µs; 697.548µs] or [-0.022%; +0.022%] | None | None | None |
| flagevaluation_evp/coalescer/typical/100flags_50users_10fields | throughput | [143359.990op/s; 143422.578op/s] or [-0.022%; +0.022%] | None | None | None |
Baseline
Baseline benchmark details
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | ce77b3f | 1792519980 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| flagevaluation_evp/payloads/scale/2500flags_500users_20fields | execution_time | 33.683ms | 34.473ms ± 0.228ms | 34.480ms ± 0.160ms | 34.636ms | 34.809ms | 34.945ms | 35.098ms | 1.79% | -0.252 | 0.137 | 0.66% | 0.016ms | 1 | 200 |
| flagevaluation_evp/payloads/scale/2500flags_500users_20fields | throughput | 71228.933op/s | 72523.634op/s ± 480.907op/s | 72506.040op/s ± 334.655op/s | 72865.688op/s | 73333.319op/s | 73692.041op/s | 74221.569op/s | 2.37% | 0.293 | 0.186 | 0.66% | 34.005op/s | 1 | 200 |
| flagevaluation_evp/payloads/stress/10flags_1000users_250fields | execution_time | 177.440ms | 178.486ms ± 0.384ms | 178.471ms ± 0.236ms | 178.728ms | 179.113ms | 179.448ms | 179.606ms | 0.64% | 0.133 | 0.127 | 0.21% | 0.027ms | 1 | 200 |
| flagevaluation_evp/payloads/stress/10flags_1000users_250fields | throughput | 5567.744op/s | 5602.721op/s ± 12.062op/s | 5603.148op/s ± 7.398op/s | 5610.250op/s | 5621.745op/s | 5628.227op/s | 5635.708op/s | 0.58% | -0.120 | 0.121 | 0.21% | 0.853op/s | 1 | 200 |
| flagevaluation_evp/payloads/typical/100flags_50users_10fields | execution_time | 828.643µs | 831.299µs ± 1.205µs | 831.215µs ± 0.701µs | 831.941µs | 833.490µs | 834.504µs | 834.692µs | 0.42% | 0.353 | 0.016 | 0.14% | 0.085µs | 1 | 200 |
| flagevaluation_evp/payloads/typical/100flags_50users_10fields | throughput | 119804.675op/s | 120293.920op/s ± 174.299op/s | 120305.837op/s ± 101.465op/s | 120404.969op/s | 120561.244op/s | 120629.746op/s | 120679.178op/s | 0.31% | -0.345 | 0.007 | 0.14% | 12.325op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| flagevaluation_evp/payloads/scale/2500flags_500users_20fields | execution_time | [34.441ms; 34.505ms] or [-0.092%; +0.092%] | None | None | None |
| flagevaluation_evp/payloads/scale/2500flags_500users_20fields | throughput | [72456.985op/s; 72590.283op/s] or [-0.092%; +0.092%] | None | None | None |
| flagevaluation_evp/payloads/stress/10flags_1000users_250fields | execution_time | [178.432ms; 178.539ms] or [-0.030%; +0.030%] | None | None | None |
| flagevaluation_evp/payloads/stress/10flags_1000users_250fields | throughput | [5601.050op/s; 5604.393op/s] or [-0.030%; +0.030%] | None | None | None |
| flagevaluation_evp/payloads/typical/100flags_50users_10fields | execution_time | [831.132µs; 831.466µs] or [-0.020%; +0.020%] | None | None | None |
| flagevaluation_evp/payloads/typical/100flags_50users_10fields | throughput | [120269.764op/s; 120318.076op/s] or [-0.020%; +0.020%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | ce77b3f | 1792519980 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 256.649µs | 263.442µs ± 12.248µs | 260.518µs ± 1.512µs | 262.664µs | 273.975µs | 317.730µs | 390.233µs | 49.79% | 7.085 | 62.002 | 4.64% | 0.866µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [261.745µs; 265.140µs] or [-0.644%; +0.644%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | ce77b3f | 1792519980 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 155.558ns | 159.537ns ± 2.752ns | 159.115ns ± 1.575ns | 160.710ns | 164.351ns | 167.587ns | 171.544ns | 7.81% | 1.327 | 2.332 | 1.72% | 0.195ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [159.155ns; 159.918ns] or [-0.239%; +0.239%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | ce77b3f | 1792519980 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| flagevaluation_evp/coalescer/scale/2500flags_500users_20fields | execution_time | 30.695ms | 30.924ms ± 0.067ms | 30.924ms ± 0.039ms | 30.966ms | 31.022ms | 31.106ms | 31.117ms | 0.62% | -0.239 | 1.130 | 0.22% | 0.005ms | 1 | 200 |
| flagevaluation_evp/coalescer/scale/2500flags_500users_20fields | throughput | 80341.212op/s | 80842.454op/s ± 176.225op/s | 80843.123op/s ± 101.420op/s | 80936.048op/s | 81156.965op/s | 81363.268op/s | 81446.896op/s | 0.75% | 0.259 | 1.143 | 0.22% | 12.461op/s | 1 | 200 |
| flagevaluation_evp/coalescer/stress/10flags_1000users_250fields | execution_time | 186.400ms | 187.645ms ± 1.653ms | 187.059ms ± 0.216ms | 187.344ms | 192.326ms | 192.516ms | 192.660ms | 2.99% | 2.352 | 3.839 | 0.88% | 0.117ms | 1 | 200 |
| flagevaluation_evp/coalescer/stress/10flags_1000users_250fields | throughput | 5190.484op/s | 5329.620op/s ± 45.996op/s | 5345.904op/s ± 6.169op/s | 5350.392op/s | 5356.682op/s | 5362.090op/s | 5364.820op/s | 0.35% | -2.344 | 3.813 | 0.86% | 3.252op/s | 1 | 200 |
| flagevaluation_evp/coalescer/typical/100flags_50users_10fields | execution_time | 690.044µs | 691.826µs ± 0.848µs | 691.720µs ± 0.611µs | 692.417µs | 693.379µs | 693.935µs | 694.441µs | 0.39% | 0.479 | -0.135 | 0.12% | 0.060µs | 1 | 200 |
| flagevaluation_evp/coalescer/typical/100flags_50users_10fields | throughput | 144000.803op/s | 144545.132op/s ± 177.150op/s | 144567.130op/s ± 127.602op/s | 144676.564op/s | 144790.160op/s | 144869.799op/s | 144918.325op/s | 0.24% | -0.473 | -0.144 | 0.12% | 12.526op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| flagevaluation_evp/coalescer/scale/2500flags_500users_20fields | execution_time | [30.915ms; 30.934ms] or [-0.030%; +0.030%] | None | None | None |
| flagevaluation_evp/coalescer/scale/2500flags_500users_20fields | throughput | [80818.031op/s; 80866.877op/s] or [-0.030%; +0.030%] | None | None | None |
| flagevaluation_evp/coalescer/stress/10flags_1000users_250fields | execution_time | [187.416ms; 187.874ms] or [-0.122%; +0.122%] | None | None | None |
| flagevaluation_evp/coalescer/stress/10flags_1000users_250fields | throughput | [5323.246op/s; 5335.995op/s] or [-0.120%; +0.120%] | None | None | None |
| flagevaluation_evp/coalescer/typical/100flags_50users_10fields | execution_time | [691.709µs; 691.944µs] or [-0.017%; +0.017%] | None | None | None |
| flagevaluation_evp/coalescer/typical/100flags_50users_10fields | throughput | [144520.581op/s; 144569.684op/s] or [-0.017%; +0.017%] | None | None | None |
What does this PR do?
Require an explicit boolean
doLogin every UFC allocation. Missing,null, and incorrectly typed values reject the affected flag withPARSE_ERROR. Other flags remain usable. Explicittrueandfalseretain their behavior.Motivation
The UFC schema requires
doLog, but the Rust decoder currently defaults an omitted value totrue. This silently enables exposure logging for malformed configuration.Additional Notes
Pins the shared cases from DataDog/ffe-system-test-data#51. Python, Ruby, and PHP must consume a libdatadog release or dependency revision containing this change.
How to test the change?
Parser tests and 321 shared fixture cases cover valid booleans, omission,
null, wrong types, invalid allocations before and after a match, and valid neighboring flags. The existing FFI test checksERROR/PARSE_ERRORpropagation. The native suites pass: 94 tests, none skipped.Consumer system tests are not completed for
096a3cc012cb895a23a6738e1df480c7201193e7. Native tests do not prove Python, Ruby, or PHP runtime integration.