Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detach_path always calls cJSON_DetachItemFromObject, so cJSONUtils_ApplyPatchesCaseSensitive resolves the target of remove, replace and move case-insensitively even though the rest of the patch code honors the flag. Applying [{"op":"remove","path":"/role"}] to {"Role":"user","role":"admin"} removes "Role" and leaves "role":"admin" in place, and removing "/a" from {"A":1} succeeds when it should fail. This picks cJSON_DetachItemFromObjectCaseSensitive when case_sensitive is set, the same way apply_patch already handles the add side, and adds patch test cases for it.