Skip to content

honor case_sensitive in detach_path for object members #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nabhan06 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

honor case_sensitive in detach_path for object members #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cJSON_Utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,14 @@ static cJSON *detach_path(cJSON *object, const unsigned char *path, const cJSON_
}
else if (cJSON_IsObject(parent))
{
detached_item = cJSON_DetachItemFromObject(parent, (char*)child_pointer);
if (case_sensitive)
{
detached_item = cJSON_DetachItemFromObjectCaseSensitive(parent, (char*)child_pointer);
}
else
{
detached_item = cJSON_DetachItemFromObject(parent, (char*)child_pointer);
}
}
else
{
Expand Down
20 changes: 19 additions & 1 deletion tests/json-patch-tests/cjson-utils-tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,23 @@
"doc": {"foo": {"bar": 1}},
"patch": [{"op": "add", "path": "/foo/bar/baz", "value": "5"}],
"error": "attempting to add to subfield of non-object"
}
},
{
"comment": "16",
"doc": {"Role": "user", "role": "admin"},
"patch": [{"op": "remove", "path": "/role"}],
"expected": {"Role": "user"}
},
{
"comment": "17",
"doc": {"Role": "user", "role": "admin"},
"patch": [{"op": "replace", "path": "/role", "value": "guest"}],
"expected": {"Role": "user", "role": "guest"}
},
{
"comment": "18",
"doc": {"A": 1},
"patch": [{"op": "remove", "path": "/a"}],
"error": "member names are case sensitive"
}
]