[DavidHLP]

Summary

Refs #2061. Enable declaration signatures for Swift callable identities while keeping bare node names and an uncapped call selector.

• Keep static/class, async, and explicit return markers. Qualified types use their last segment; the where T.Element case retains its existing spelling pending the maintainer's follow-up.
• Select receiver types before matching labels, arity, defaults, and trailing closures. Receiver facts come from declarations and direct constructor bindings. Known unindexed receivers remain unresolved, and typed calls look up their owner's overload bucket and inherited methods. Incremental proxies retain base-class metadata for unchanged receiver types.
• Capture trailing closures from both Swift AST locations and preserve chained request/response calls.
• Use language-neutral shared fields and property keys. selector_param_count is separate from the existing param_count complexity metric.
• Use index format 5 with one history entry. Remove the branch-only format-6 step and format-5 image migration test. Keep base QNs when signature construction fails and anchor service suffix stripping to the node's name.
• Add a Swift complexity fixture and regression coverage for receiver collisions, standard-library values, lexical shadowing, chained closures, and lifecycle overloads.

Integration

Merged current main at 8530c8cd1c1ac8e1e3d2962bc213a8c9025fea0a, retaining scoped resolution, module-aware registration, and per-field property sizing.

The branch also integrates the pending #2395 head (b5b16e092c8676a8b1eb645d1ea7cf7846274efb) to exercise lifecycle compatibility. Its tests now use signature QNs. The graph tests distinguish initializer overloads, select the matching Base.init(name:), and refuse an external UIViewController.init(nibName:bundle:) despite a label-compatible project initializer. self.init retains #2395's no-edge policy.

Validation

AI assistance: This update was prepared with an AI agent acting on behalf of DavidHLP.

• At debefaff, the canonical runner's focused selection passed 196 tests with ASan/UBSan and UBSAN_OPTIONS=halt_on_error=1. This runs all callable-signature, registry, index-format, and complexity tests plus the Swift extraction, pipeline, known-class, and MCP cases. The separate full registry run passed 112 tests; these counts overlap.
• The receiver-root scan now uses the initialized buffer length. The analyzer's uninitialized-read report no longer occurs. Its pre-existing cognitive-complexity warning is unchanged at 36 on both main and this branch.
• Local cppcheck for the registry change passed with CI's pinned 2.20.0, and formatting with clang-format 20 and git diff --check passed. The earlier 2.22 diagnostics were a tool-version mismatch. The default full clang-tidy sweep still reports existing warnings, reproduced on main; no suppression or threshold was changed.
• GitHub CI for 8e91d3fe completed Linux, macOS, Windows, TSan, and lint successfully. On debefaff, Linux, Windows, TSan, and lint have passed; macOS is still queued. No failing check has been observed on the current head.

Local full-test investigation

The remaining environment and empty-input fixes are isolated in #2809, based on main 8530c8cd:

• Inherited XDG directories let fixtures reach real user configuration despite redirecting HOME. Git mnemonic prefixes also made the hunk parser lose precise seeds. The affected CLI/MCP production code matched main before the fixes.
• Perl empty sorts, ObjectScript zero-length copies, and an empty RST configuration search emitted UBSan diagnostics. The initial signature-buffer copy also needed the protection already present in this Swift branch.
• The venue-parity contract ran Bash before checking whether an entry was Python, which could invoke ImageMagick's import utility on a desktop host.
• glibc 2.44 called free(NULL) before mimalloc initialization, crashing the production binary before main. The follow-up backports the upstream mimalloc fix and adds an ELF pre-initialization regression. It also refreshes the three changed vendored-source checksums.

The follow-up branch's final canonical entry reached All tests passed with strict UBSan, including all enabled production guards. Its unit phase reported 9,802 passed, 0 failed, and 10 platform skips; a transient TLS error skipped the incremental fixture setup. A separate rerun of that suite with the same final binary passed all 164 tests, bringing the final binary's total to 9,966. Final-code CI lint and the vendored integrity check also passed. These full results belong to #2809, rather than this Swift head.

The maintainer's requested Swift call-graph census and final review remain pending.

[github-actions]

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

• It will not be closed for inactivity. No stale bot touches pull requests here.
• It may still sit a while before a human reads it. That is on us, not on you.
• Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

• Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
• Get CI green, or say which failures you believe are pre-existing.
• Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
• Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

[DeusData]

Thank you for the detailed status update and for clearly distinguishing the actual PR head from unpublished work and unverified results. The changed-file scope includes callable identity, resolution and persisted metadata, so we need more time for a complete review together with the parent change. This remains queued for deeper review; this comment is not an approval or a request for another routine rebase. The queue is full, and we appreciate your patience and the care taken to document the remaining work.

[DeusData]

Thanks for the Swift identity update and for distinguishing current-head checks from earlier implementation validation. I have read your request for feedback on identity spelling and the migration boundary; those decisions remain on the maintainer side. Please hold off on further routine rebases while that review is pending.

[DeusData]

Thank you for the Swift identity measurements and the migration questions. Those decisions remain on our side; please continue to hold off on routine rebases while that review is pending. Sorry for the delay—I’ll follow up soon.

[DeusData]

Thank you, @DavidHLP, for carrying the Swift identity on top of #2342 exactly as we proposed on #2061, for your patience while we held the spelling and migration questions on our side, and for the care in this branch. Keeping the selector uncapped and separate from the bounded identity, carrying it through serial, parallel and incremental indexing, and filtering candidates before the output limit are all the right calls. Here are our decisions on the questions you asked, and what we need before this can land. The hold on updates is lifted: please bring the branch up to current main (merging main in is fine).

We built your current head (4885230) and indexed Alamofire (bda9ed57) with it. The core fix works: on the #2061 repro, work(flag:Bool) and work(name:String) are separate nodes, onlyCallsOverloadB reaches only work(name:String), and the fake path to target() is gone. On Alamofire, 74 overload sets that were one node each are split into 404 nodes, including all 13 Session.upload overloads, and repeated runs give an identical graph.

1. Identity spelling. Please keep the static/class and async markers and the explicit =>Return. They separate real Swift overloads: Alamofire's three encode(_:any Encodable) differ only in their return type. For qualified types, please use the last segment, as in the #2342 contract, instead of / paths. Two declarations that differ only in the scope of a same-named parameter type then stay one node, as they are on main today. That case is rare, and it keeps Swift QNs consistent with the other languages. One detail we will confirm separately: associated types of a generic parameter in a where-requirement (for example where T.Element == Int). Please keep your current spelling for that one case until we follow up on it.

2. Keep the receiver's type in charge. The label block in resolve_single_call (and its twin in pass_parallel.c) runs before the registry's receiver-typed strategies and returns early, so the label shape can override the receiver's declared type. On Alamofire, swift_labels resolves 3,650 CALLS while field_type_hint resolutions fell from 884 to 1 compared with main at the time. In Tests/CachedResponseHandlerTests.swift:41, session is a Session, but session.request(.default) resolves to DataResponsePublisher.Inner.request(_:Subscribers/Demand) with candidates:1. That one pattern adds 175 edges from tests to the Combine Inner.request methods, the same kind of fake caller #2061 is about. Calls on standard-library values get bound too: output.sorted() on a [String] in URLEncodedFormEncoder.swift:1076 points at HTTPHeaders.sorted(). Please apply the label and arity filter inside the receiver-typed candidates rather than in front of them, and leave a call unresolved when the receiver is a known non-project type. A regression test with a typed receiver whose method shares its label shape with an unrelated class would pin this.

3. Chained calls with trailing closures. Some calls that main resolves are dropped, for example session.request(.default).responseDecodable(of:) { ... } (Tests/SessionTests.swift:1632) and session.streamRequest(...).responseStream { ... } (Tests/DataStreamTests.swift:582). These are common Swift idioms, so a test for each would be very welcome.

4. Language-neutral names for the new fields. CBMDefinition and CBMCall are shared by every language, and Kotlin, Scala and C# will need default-argument and trailing-lambda matching when their identity changes land. Please give the new struct fields and the persisted property keys neutral names (for example param_default_mask, param_count, call_selector and trailing_closure_*), so those changes can reuse them.

5. Index format 5. main is at index format 4 (#1913, receiver-qualified Go methods), so this change becomes format 5 with a single history entry. The format-6 step and the format-5 image migration test cover a state that only existed on this branch (main already stopped inventing image hosts in format 3), so please drop both. When you update the branch you will see conflicts in pass_calls.c (main now resolves through cbm_registry_resolve_call_scoped), pass_definitions.c and pass_parallel.c (main reworked the def-properties sizing into per-field helpers, so the selector becomes one more term there, and registration now goes through cbm_registry_add_lang_in_module), pipeline_incremental.c, pipeline.h and store.h.

6. Initializers. #2395 is about to land and makes Swift init and deinit callable definitions (Box.init becomes a Method node). Because the identity applies to every callable, your branch will give them signature QNs too, for example Box.init(name:String), and Box.deinit() under the zero-argument rule, which is what we want. Please update the #2395 tests that look up the unsuffixed Box.init and Deinitable.deinit definitions, and add tests where two init overloads stay separate nodes, a super.init call reaches the matching Base.init overload, and an external UIViewController.init(nibName:bundle:) with a label-compatible project init forms no edge. #2395 makes self.init form no edge because overloads used to share one node; we will revisit that separately once your change is in, so please leave it as it is.

7. Three smaller points from reading the code:
   a. When the signature cannot be built, extract_func_def, push_method_def and compute_func_qn now return without a definition or QN. Please fall back to the plain base QN instead, so a definition is never lost.
   b. cbm_service_pattern_match now strips a callable suffix for every language with cbm_qn_callable_base_len. Other languages' QNs can end in ')' for other reasons, so please use the name-anchored form or limit it to Swift.
   c. cbm_registry_swift_candidates scans the whole same-name bucket and allocates on every call. With initializers in the graph, init becomes by far the largest Swift bucket, so the cost grows with initializers times calls. Please look up the named type's overloads directly when the call has a type receiver, and drop a small Swift fixture into tests/fixtures/complexity/ so the complexity suite covers it (no test code change is needed there).

Before merging we will run a Swift call-graph census on the updated branch ourselves (Alamofire, one larger Swift project and a non-Swift control), so you do not need to produce those numbers.

To be clear about what is already good here: outside the session.request cluster, a random sample of call sites whose target changed came out better with your branch than with main (3 fixed, none broken, the rest wrong either way), and most of the 372 calls that only your branch resolves are correct, for example Interceptor(adapter:retrier:) and self.state.write. So the label matching itself is a real gain; it just must not override the receiver.

Thank you again for the very careful work on this, and sorry it took us a while to come back with the decisions.

[DavidHLP]

Following up on your review: I have addressed the requested contributor-side changes at debefaff45f4c77b9ba17a87d1d707eacc8d8345.

1. Identity spelling: kept static/class, async, and explicit =>Return markers; qualified types now use the last segment. The generic associated-type where T.Element case retains its existing spelling pending your follow-up.
2. Receiver precedence: label/arity/default/trailing-closure matching now filters receiver-typed candidates. Known non-project receivers stay unresolved. Regressions cover unrelated classes with the same label shape, standard-library values, and lexical shadowing.
3. Chained trailing closures: added coverage for request/responseDecodable and streamRequest/responseStream chains, including both Swift AST locations for trailing closures.
4. Shared metadata: new fields and persisted keys are language-neutral. selector_param_count is distinct from the existing complexity metric param_count.
5. Integration and index format: merged main at 8530c8cd, retaining scoped resolution, module-aware registration, and per-field property sizing. The index format is 5 with one history entry; the branch-only format-6 step and format-5 image migration test are removed.
6. Initializers: integrated fix(extraction): attribute Swift lifecycle calls #2395's b5b16e09 head for compatibility testing and updated its signature-QN lookups. Tests cover separate init overloads, matching super.init, and no edge to a label-compatible project initializer from an external UIViewController initializer. self.init retains the requested no-edge policy.
7. Smaller fixes: signature-construction failure falls back to the base QN; service suffix stripping is name-anchored; typed receivers use their owner's overload bucket instead of scanning the full same-name bucket. A Swift fixture now participates in the existing complexity suite.

Validation on this PR head: 196 focused tests passed under ASan/UBSan with UBSAN_OPTIONS=halt_on_error=1; the separate registry suite passed 112 tests (overlapping coverage). Current-head Linux, macOS, Windows, TSan, lint, security, DCO, and the aggregate ci-ok check have now passed.

The local full clang-tidy sweep still reports pre-existing warnings reproduced on main; I have not changed its thresholds or suppressions. Other local full-test problems were reproduced against main's implementations and isolated in #2809, rather than added to this Swift PR. Those findings are now tracked in #2814 for a maintainer decision, with #2809 retained as a draft candidate. Its full-test results are not being presented as validation of this PR's head.

I believe the requested code changes are complete and this is ready for your Swift call-graph census and final review. As you specified, the census of Alamofire, a larger Swift project, and a non-Swift control remains on the maintainer side.