Repository navigation
Conversation
Signed-off-by: DavidHLP <lysf15520112973@163.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Signed-off-by: DavidHLP <lysf15520112973@163.com>
Signed-off-by: DavidHLP <lysf15520112973@163.com>
Backport microsoft/mimalloc@b2226c1 for issue DeusData#1341. Seed both page-map layouts before constructors run and preserve the empty map on initialization failure. Add a release-mode ELF preinitializer regression and track included allocator sources in test and TSan object dependencies. Signed-off-by: DavidHLP <lysf15520112973@163.com>
Signed-off-by: DavidHLP <lysf15520112973@163.com>
DavidHLP
marked this pull request as ready for review
October 26, 2026 16:59
DavidHLP
marked this pull request as draft
October 27, 2026 00:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer decision pending
Findings, reproductions, and validation are tracked in #2814. This draft preserves a candidate patch for inspection. Please decide which issues should be fixed and how accepted work should be split before this PR proceeds; it is not a prerequisite for #2436.
Summary
Redirecting HOME did not isolate the C runner when XDG directories still pointed at the developer's real configuration. Clear those inherited overrides alongside the existing client overrides and extend the fixture contract.
detect_changesalso inherited Git's mnemonic prefixes, while its hunk parser expects+++ b/. This made precise hunk seeds fall back to whole-file seeds. Reuse the existing test-impact Git pins and diff flags, and run the walk fixture with mnemonic prefixes enabled.Skip empty Perl package/declaration sorts and zero-length ObjectScript scanner copies. These existing extraction/pipeline cases previously emitted UBSan diagnostics for null arguments.
The strict full run also exposed an empty initial signature-buffer copy and a search of an empty RST configuration table. Guard both. The signature-buffer safeguard already exists in #2436; this applies the same protection to main. Extend the existing Perl documentation case with POD containing no function declarations.
Dispatch Python help probes directly to Python in the venue-parity contract. Previously it invoked Bash first, which could run ImageMagick's
importcommand and wait for graphical input on a desktop host.The pre-fix implementations are from main at
8530c8cd. These issues were found while investigating local failures around #2436 and are kept separate from its Swift changes.On glibc 2.44, the production binary also crashed before
mainwhen libc calledfree(NULL)before mimalloc initialization. Backport the small upstream microsoft/mimalloc fix for issue #1341. Add an ELF pre-initialization regression and missing mimalloc object dependencies. Refresh the three reviewed vendored-source checksums.Validation
diff.mnemonicPrefix=truereproduced the hunk-seed failure and the assertion-exit leak reports.tests/test_smoke_fixture_contract.sh: passed.tests/test_venue_parity_contract.sh: passed after the interpreter correction.scripts/lint.sh --ciwith CI's cppcheck 2.20.0 and clang-format 20: passed on the final code.git diff --check: passed.scripts/test.shentry withUBSAN_OPTIONS=halt_on_error=1reachedAll tests passed, including production guards. Its unit phase reported 9,802 passed, 0 failed, 10 platform skips. The incremental suite initially skipped setup after a transient TLS fixture-clone failure; its separate rerun with the same binary passed all 164 tests without sanitizer diagnostics. Together, the final binary passed 9,966 tests.