Repository navigation
fix(threads): preserve server-provided names - #619
mrnwebdesigns wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 656142fd74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const name = customName | ||
| ? customName | ||
| : clampThreadName(preview) ?? fallbackName; | ||
| : clampThreadName(serverName || preview) ?? fallbackName; |
There was a problem hiding this comment.
Ignore UUID placeholder names when building summaries
When the server-provided name is the thread's UUID and no local rename exists, this now chooses the UUID over a useful message preview. onThreadNameUpdated already rejects this exact placeholder in useThreadTurnEvents.ts:172–178, with a corresponding regression test, but list refreshes now bypass that safeguard and replace readable sidebar labels with IDs. Apply the same placeholder check before preferring the server name so these sessions retain the preview or numbered-agent fallback.
Useful? React with 👍 / 👎.
Summary
titleas a compatibility fallback whennameis unavailable.Why
Imported or externally named chats can already have a useful server-provided name. Replacing it with the first-message preview makes those chats harder to identify and can make the sidebar disagree with the source application.
Testing
npm run typecheckvitest run src/features/threads/utils/threadSummary.test.ts— 4 tests passedvitest run— 139 test files and 1,003 tests passed