Repository navigation
fix(threads): preserve server-provided names #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrnwebdesigns
wants to merge
1
commit into
Dimillian:main
Choose a base branch
from
mrnwebdesigns:contrib/preserve-server-thread-titles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { buildThreadSummaryFromThread } from "./threadSummary"; | ||
|
|
||
| const baseThread = { | ||
| id: "thread-1", | ||
| name: "Server-provided name", | ||
| preview: "First message preview", | ||
| source: "vscode", | ||
| }; | ||
|
|
||
| describe("buildThreadSummaryFromThread", () => { | ||
| it("prefers the server-provided thread name over the message preview", () => { | ||
| const summary = buildThreadSummaryFromThread({ | ||
| workspaceId: "workspace-1", | ||
| thread: baseThread, | ||
| fallbackIndex: 0, | ||
| }); | ||
|
|
||
| expect(summary?.name).toBe("Server-provided name"); | ||
| }); | ||
|
|
||
| it("keeps an explicit local rename ahead of the server-provided name", () => { | ||
| const summary = buildThreadSummaryFromThread({ | ||
| workspaceId: "workspace-1", | ||
| thread: baseThread, | ||
| fallbackIndex: 0, | ||
| getCustomName: () => "Local rename", | ||
| }); | ||
|
|
||
| expect(summary?.name).toBe("Local rename"); | ||
| }); | ||
|
|
||
| it("falls back to the message preview when the server has no name", () => { | ||
| const summary = buildThreadSummaryFromThread({ | ||
| workspaceId: "workspace-1", | ||
| thread: { ...baseThread, name: null }, | ||
| fallbackIndex: 0, | ||
| }); | ||
|
|
||
| expect(summary?.name).toBe("First message preview"); | ||
| }); | ||
|
|
||
| it("supports title as a compatibility fallback", () => { | ||
| const summary = buildThreadSummaryFromThread({ | ||
| workspaceId: "workspace-1", | ||
| thread: { ...baseThread, name: null, title: "Legacy title" }, | ||
| fallbackIndex: 0, | ||
| }); | ||
|
|
||
| expect(summary?.name).toBe("Legacy title"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the server-provided
nameis the thread's UUID and no local rename exists, this now chooses the UUID over a useful message preview.onThreadNameUpdatedalready rejects this exact placeholder inuseThreadTurnEvents.ts:172–178, with a corresponding regression test, but list refreshes now bypass that safeguard and replace readable sidebar labels with IDs. Apply the same placeholder check before preferring the server name so these sessions retain the preview or numbered-agent fallback.Useful? React with 👍 / 👎.