refactor(vmm): remove OCI registry image pull - #1282
Merged
Merged
Conversation
This was referenced Sep 20, 2026
kvinwang
force-pushed
the
fix/vmm-parser-bounds
branch
from
September 24, 2026 08:32
c2f6562 to
5e3c60a
Compare
kvinwang
changed the title
Guest images are not published to an OCI registry and there is no plan to, so the registry client in dstack-vmm had no users while still parsing registry-supplied manifests inside the VMM process. Remove it along with the [image] registry setting, the ListRegistryImages and PullRegistryImage RPCs, the registry section of the Images panel, and the dstack-image-oci.sh push script. The Images panel keeps listing and deleting local images.
kvinwang
force-pushed
the
fix/vmm-parser-bounds
branch
from
September 24, 2026 12:40
a0821ec to
469dffb
Compare
kvinwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guest images are not published to an OCI registry and there is no plan to, so the VMM's registry client has no users. Rather than harden its manifest and blob handling (the original scope of this PR), remove it.
Removed:
vmm/src/app/registry.rsand the[image] registrysettingListRegistryImages/PullRegistryImageRPCsos/image/dstack-image-oci.shand its docsA leftover
registryline invmm.tomlis ignored.Verification:
cargo test -p dstack-vmm, clippy and fmt clean, UI builds.