fix(vmm): bound vcpu/memory arithmetic and reject zero resources at deployment - #1364
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
round_up(app.rs) and the GiB-to-MiB multiply inconfigure_hugepage_memoryare unchecked. Release builds do not check for overflow, so an absurdvcpu/memorywraps and QEMU starts with a small-smp/-m.validate_resize_requestrejects zero vcpu/memory/disk, but deployment (create_manifest_from_vm_config) accepted them, and the VM only failed at launch.Fix
round_upkeeps the value when the next multiple would overflow, and the multiply saturates.Verification
cargo test -p dstack-vmm, fmt and clippy clean.Split out of #1282.