Repository navigation
Read final from trait aliases - #892
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=========================================
Coverage 99.70% 99.70%
- Complexity 1969 1970 +1
=========================================
Files 147 147
Lines 4479 4481 +2
=========================================
+ Hits 4466 4468 +2
Misses 13 13 ☔ View full report in Codecov by Harness. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #891.
A trait adaptation can make a method
final, with or without renaming it or changing its visibility:The server ignored the
final, so hover showed these methods without it. Worse,stop as final, with no visibility written, was read as makingstoppublic, whatever its own visibility.Change
TraitAliasrecords whether the adaptation addsfinal(addsFinal). PHP lets an adaptation addfinal, never remove it.Tests
ParsedDeclarationSourceTestreads both forms fromTraitCompositionUser, which gains a renamingas finaland afinal-only adaptation.MemberResolverTypeGraphTestnow also compares whether each public method is final with PHP's reflection, across every fixture class.🤖 Generated with Claude Code