Repository navigation
no_pins: refuse '<=' and exact '=' ceilings (#37) - #92
Merged
Merged
Conversation
…e spec and debian/control (#37)
This was referenced Oct 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
declared() now counts any '<=', '=' or '<' constraint on omx-clap-host-tests as a ceiling in packaging/plugin-hostd.spec, and '<<', '<=', '<' or '=' in debian/control. Floor-only ruling of 2026-10-15.
Tests: python3 tests/no_pins.py is green on the tree. tests/sabotage.py gains one nopins case per form ('<=', '=', '<') in each file (six cases).
Sabotage: planted each of the six forms (with <!nocheck> in debian/control so the check-stage rule does not mask it) in a scratch copy. The previous no_pins.py accepted the exact '=' form in the spec and all four non-'<' forms in debian/control (printed 'no pin anywhere'); the new one refuses all six. I did not run the full tests/sabotage.py harness.
Closes #37