fix(Output): Removed output of non transferable attributes

[MelchiorSchuh]

No description provided.

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 5 concern(s)

• include/geode/io/image/detail/vtk_output.hpp:34:1: warning: [modernize-concat-nested-namespaces]

  nested namespaces can be concatenated

     34 | namespace geode
        | ^~~~~~~~~~~~~~~
     35 | {
        | ~
     36 |     namespace detail
        |     ~~~~~~~~~~~~~~~~
        |     namespace geode::detail

• include/geode/io/image/detail/vtk_output.hpp:39:15: warning: [cppcoreguidelines-special-member-functions]

  class 'VTKOutputImpl' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator

     39 |         class VTKOutputImpl
        |               ^

• include/geode/io/image/detail/vtk_output.hpp:62:21: warning: [hicpp-use-equals-default]

  use '= default' to define a trivial destructor

     62 |             virtual ~VTKOutputImpl() {}
        |                     ^                ~~
        |                                      = default;

• include/geode/io/image/detail/vtk_output.hpp:82:18: warning: [readability-function-cognitive-complexity]

  function 'write_attributes' has cognitive complexity of 13 (threshold 10)

     82 |             void write_attributes( pugi::xml_node& attribute_node,
        |                  ^
  /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/image/detail/vtk_output.hpp:86:17: note: +1, including nesting penalty of 0, nesting level increased to 1
     86 |                 for( const auto& id : manager.attribute_ids() )
        |                 ^
  /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/image/detail/vtk_output.hpp:89:21: note: +2, including nesting penalty of 1, nesting level increased to 2
     89 |                     if( !attribute || !attribute->is_genericable()
        |                     ^
  /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/image/detail/vtk_output.hpp:90:25: note: +1
     90 |                         || !attribute->properties().transferable )
        |                         ^
  /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/image/detail/vtk_output.hpp:99:21: note: +2, including nesting penalty of 1, nesting level increased to 2
     99 |                     for( const auto e : elements )
        |                     ^
  /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/image/detail/vtk_output.hpp:101:25: note: +3, including nesting penalty of 2, nesting level increased to 3
    101 |                         for( const auto i : LRange{ attribute->nb_items() } )
        |                         ^
  /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/image/detail/vtk_output.hpp:103:29: note: +4, including nesting penalty of 3, nesting level increased to 4
    103 |                             if( !attribute->has_value( e ) )
        |                             ^

• include/geode/io/image/detail/vtk_output.hpp:86:34: warning: [readability-identifier-length]

  variable name 'id' is too short, expected at least 3 characters

     86 |                 for( const auto& id : manager.attribute_ids() )
        |                                  ^

Have any feedback or feature suggestions? Share it here.

[BotellaA]

🎉 This PR is included in version 7.8.2-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[BotellaA]

🎉 This PR is included in version 7.8.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀