Skip to content

fix(Output): Removed output of non transferable attributes #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 2 commits into from
Aug 26, 2026
Merged

fix(Output): Removed output of non transferable attributes #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f99e0bd
fix(Output): Removed output of non transferable attributes
MelchiorSchuh Aug 25, 2026
7fdeff6
fix test
BenPinet Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/geode/io/image/detail/vtk_output.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@

#include <geode/basic/attribute_manager.hpp>

namespace geode

Check warning on line 34 in include/geode/io/image/detail/vtk_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/image/detail/vtk_output.hpp:34:1 [modernize-concat-nested-namespaces] 

nested namespaces can be concatenated
{
namespace detail
{
template < typename Mesh >
class VTKOutputImpl

Check warning on line 39 in include/geode/io/image/detail/vtk_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/image/detail/vtk_output.hpp:39:15 [cppcoreguidelines-special-member-functions] 

class 'VTKOutputImpl' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
{
public:
void write_file()
Expand All @@ -59,7 +59,7 @@
"[VTKOutput] Error while writing file: ", filename );
}

virtual ~VTKOutputImpl() {}

Check warning on line 62 in include/geode/io/image/detail/vtk_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/image/detail/vtk_output.hpp:62:21 [hicpp-use-equals-default] 

use '= default' to define a trivial destructor

const Mesh& mesh() const
{
Expand All @@ -79,14 +79,15 @@
write_attributes( attribute_node, manager, elements );
}

void write_attributes( pugi::xml_node& attribute_node,

Check warning on line 82 in include/geode/io/image/detail/vtk_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/image/detail/vtk_output.hpp:82:18 [readability-function-cognitive-complexity] 

function 'write_attributes' has cognitive complexity of 13 (threshold 10)
const AttributeManager& manager,
absl::Span< const index_t > elements ) const
{
for( const auto& id : manager.attribute_ids() )

Check warning on line 86 in include/geode/io/image/detail/vtk_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/image/detail/vtk_output.hpp:86:34 [readability-identifier-length] 

variable name 'id' is too short, expected at least 3 characters
{
const auto attribute = manager.find_generic_attribute( id );
if( !attribute || !attribute->is_genericable() )
if( !attribute || !attribute->is_genericable()
|| !attribute->properties().transferable )
{
continue;
}
Expand Down
1 change: 0 additions & 1 deletion tests/model/test-vtm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ int main()
absl::StrCat( geode::DATA_PATH, "mss_cut_section.og_sctn" ) );
const auto filename2 = absl::StrCat( "mss_cut_section.vtm" );
geode::save_section( section, filename2 );

geode::Logger::info( "TEST SUCCESS" );
return 0;
}
Expand Down
Loading