Skip to content

[Refactoring] Badge: Remove legacy filesystem image paths - #12326

Merged
fhelfer merged 2 commits into
ILIAS-eLearning:trunkfrom
fhelfer:badge/removal/legacy-image-paths
Oct 30, 2026
Merged

fhelfer merged 2 commits into
ILIAS-eLearning:trunkfrom
fhelfer:badge/removal/legacy-image-paths

Conversation

@fhelfer

@fhelfer fhelfer commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the badge and badge-template filesystem migrations. They have been available long enough that ILIAS 12 only keeps resource ids.
  • Delete the runtime fallback that still read, uploaded, or signed unmigrated images from sec/ilBadge (ilFSStorageBadge, ilFSStorageBadgeImageTemplate, ilBadgeWAC).
  • Drop the obsolete image filename column and clear the migration placeholder '-' in database update step 3.
  • The second commit is PHP-CS-Fixer formatting only, so the path removal can be reviewed on its own.

Open Badges static publishing under pub_badges/ is unchanged.

Test plan

  • Run the database update and confirm badge_badge.image and badge_image_template.image are gone.
  • Reload the control structure so ilBadgeWAC is no longer registered.
  • Create and edit a badge image by upload and from a template.
  • Clone a course or badge and confirm the image resource is copied.
  • Delete a badge and a template and confirm the resource storage entry is removed.
  • phpunit --no-coverage --do-not-cache-result components/ILIAS/Badge/tests

@fhelfer fhelfer self-assigned this Oct 29, 2026
@mjansenDatabay mjansenDatabay added improvement php Pull requests that update Php code labels Oct 29, 2026
Drop the IRSS file migrations and the runtime fallback that still
served unmigrated badge images from sec/ilBadge. Badges and templates
now use resource ids only.
@fhelfer
fhelfer force-pushed the badge/removal/legacy-image-paths branch from 333e08b to 888e130 Compare October 29, 2026 11:44
@mjansenDatabay

mjansenDatabay commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

@fhelfer IMO you should squash the commit before merge.

@fhelfer
fhelfer merged commit 22fc7ac into ILIAS-eLearning:trunk Oct 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants