Repository navigation
[Refactoring] Badge: Remove legacy filesystem image paths - #12326
Merged
fhelfer merged 2 commits intoOct 30, 2026
Merged
Conversation
Drop the IRSS file migrations and the runtime fallback that still served unmigrated badge images from sec/ilBadge. Badges and templates now use resource ids only.
fhelfer
force-pushed
the
badge/removal/legacy-image-paths
branch
from
October 29, 2026 11:44
333e08b to
888e130
Compare
mjansenDatabay
approved these changes
Oct 29, 2026
Contributor
|
@fhelfer IMO you should squash the commit before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sec/ilBadge(ilFSStorageBadge,ilFSStorageBadgeImageTemplate,ilBadgeWAC).imagefilename column and clear the migration placeholder'-'in database update step 3.Open Badges static publishing under
pub_badges/is unchanged.Test plan
badge_badge.imageandbadge_image_template.imageare gone.ilBadgeWACis no longer registered.phpunit --no-coverage --do-not-cache-result components/ILIAS/Badge/tests