[Refactoring] Badge: Remove legacy filesystem image paths

components/ILIAS/Badge/ROADMAP.md

@@ -4,8 +4,4 @@
 
 ### Introduction of UI elements
 
-More elements of the UI framework should be used for the user interface.
-
-### IRSS Integration
-
-Files should be handled by the IRSS
+More elements of the UI framework should be used for the user interface.

components/ILIAS/Badge/classes/Modal.php

@@ -21,21 +21,15 @@
 namespace ILIAS\Badge;
 
 use ILIAS\DI\Container;
-use Closure;
 use ILIAS\UI\Component\Component;
-use ilWACSignedPath;
 
 class Modal
 {
-    /** @var Closure(string): string */
-    private readonly Closure $sign_file;
     private ilBadgeImage $badge_image_service;
 
     public function __construct(
-        private readonly Container $container,
-        $sign_file = [ilWACSignedPath::class, 'signFile']
+        private readonly Container $container
     ) {
-        $this->sign_file = Closure::fromCallable($sign_file);
         $this->badge_image_service = new ilBadgeImage(
             $container->resourceStorage(),
             $container->upload(),

components/ILIAS/Badge/classes/Setup/class.ilBadgeDBUpdateSteps.php

@@ -58,4 +58,26 @@ public function step_2(): void
             );
         }
     }
+
+    public function step_3(): void
+    {
+        $this->db->manipulate(
+            'UPDATE badge_badge SET image_rid = NULL WHERE image_rid = ' . $this->db->quote(
+                '-',
+                ilDBConstants::T_TEXT
+            )
+        );
+        $this->db->manipulate(
+            'UPDATE badge_image_template SET image_rid = NULL WHERE image_rid = ' . $this->db->quote(
+                '-',
+                ilDBConstants::T_TEXT
+            )
+        );
+        if ($this->db->tableColumnExists('badge_badge', 'image')) {
+            $this->db->dropTableColumn('badge_badge', 'image');
+        }
+        if ($this->db->tableColumnExists('badge_image_template', 'image')) {
+            $this->db->dropTableColumn('badge_image_template', 'image');
+        }
+    }
 }

components/ILIAS/Badge/classes/Setup/class.ilBadgeSetupAgent.php

@@ -31,12 +31,4 @@ public function getStatusObjective(?Setup\Metrics\Storage $storage): Setup\Objec
     {
         return new ilDatabaseUpdateStepsMetricsCollectedObjective($storage, new ilBadgeDBUpdateSteps());
     }
-
-    public function getMigrations(): array
-    {
-        return [
-            new ilBadgesFilesMigration(),
-            new ilBadgeTemplatesFilesMigration()
-        ];
-    }
 }