Conversation
Fixes precompilation on Julia LTS. `TensorAlgebra.one` is a tensor generalization rather than an extension of `Base.one`, but its docstring ended with a bare `one` instead of `function one end`, so the module never got its own binding and Julia 1.10 rejected the method definitions as extending `Base.one` without importing it. Declared now the way `dual` and `isdual` are. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 74.78% 79.64% +4.85%
==========================================
Files 27 28 +1
Lines 1047 1056 +9
==========================================
+ Hits 783 841 +58
+ Misses 264 215 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes precompilation on Julia LTS.
TensorAlgebra.oneis a tensor generalization rather than an extension ofBase.one, but its docstring ended with a bareoneinstead offunction one end, so the module never got its own binding and Julia 1.10 rejected the method definitions as extendingBase.onewithout importing it. Declared now the waydualandisdualare.