Skip to content

Fix precompilation on Julia LTS #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mtfishman wants to merge 1 commit into from
Closed

Fix precompilation on Julia LTS #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/factorizations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,8 +842,8 @@ partition is specified either via labels or directly through a bi-permutation;
fused codomain and domain sizes must match. `A` is treated as a shape prototype
and is not mutated.

Not exported, since exporting would clash with the implicit `Base.one`. Qualify
as `TensorAlgebra.one(A, ...)`.
A tensor generalization in its own right, not an extension of `Base.one`, so it is neither
exported nor imported. Qualify as `TensorAlgebra.one(A, ...)`.

See also `MatrixAlgebraKit.one!`.

Expand All @@ -862,7 +862,7 @@ julia> matricize(Id, Val(2)) ≈ I
true
```
"""
one
function one end

function one!!(style::MatricizeStyle, A, ndims_codomain::Val; kwargs...)
A_mat = matricize(style, A, ndims_codomain)
Expand Down