Repository navigation
feat(chip): update samples - #1118
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
16 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iteUI/igniteui-react-examples into iminchev/update-chip-samples
Hristo313
added
status: verified
Hristo313
approved these changes
Oct 19, 2026
Bring in the Astro migration (#1110), the sample type check (#1132) and AGENTS.md (#1133). Conflicts: chip outlined, overview, size and styling. This branch had already rewritten them as function components with new content, so its side is kept, in vnext's style: no JSX.Element return type, which React 19's types no longer declare, no unused React import, and the `getElementById('root')!` mount. The seven new chip samples (area, interaction-state, layout, remove, state, tailwind-styling, types) get what vnext did to every sample: no sandbox.config.json, README.md (tailwind-styling had ReadMe.md) in the current format without the CodeSandbox link, the strict add:sample tsconfig, and package versions from scripts/lib/versions.js. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tailwind-styling sample rendered unstyled in the Astro build. Its stylesheet put the Aktiv Grotesk @import before the @layer statement, and the samples browser compiles sample CSS through Vite, whose @import handling then drops the Tailwind imports that follow: the page got 151 bytes of CSS instead of the theme and utilities. Standalone, Tailwind's own Vite plugin handles the imports, which hid this. Put the @layer statement first and the font import right after it. The page now inlines the palette and all 24 utilities the sample uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ChronosSF
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to IgniteUI/igniteui-documentation#701