fix: remove unused device placeholders#790
Merged
Merged
Conversation
This was referenced Jul 10, 2026
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kKunlunandkQydevice placeholders fromsrc/device.h, Python device parsing, Torch device naming, and Torch explicit instantiations.Kunlun/Qyentries from wrapper and Torch codegen device lists.Motivation
InfiniRT is removing the unused
kKunlunandkQyplaceholders in InfiniTensor/InfiniRT#24. InfiniOps aliasesinfini::rt::Device, so keeping these enum references would break builds once InfiniOps is built against that InfiniRT branch.Closes N/A
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Full `pytest` output (optional)
Benchmark / Performance Impact
N/A - this removes unused device placeholders and does not change kernels or algorithms.
Notes for Reviewers
This PR is intended to be merged with or after InfiniTensor/InfiniRT#24. The validation above builds InfiniOps against that InfiniRT branch to cover the cross-repo compatibility boundary.