fix: remove unused device type placeholders#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kKunlunandkQydevice type placeholders fromDevice::Type.AllDeviceTypesentries so the active device list only covers implemented backends.Motivation
KunlunandQydo not have CMake options, generated public-header mappings, or native runtime/device implementations yet. Keeping them in the public device enum makes them look supported before the backend support exists.Smoke Build / Test Evidence
rg -n "kKunlun|kQy|kunlun|qy" .returned no matches after the change.git diff --checkpassed.python -m py_compile scripts/generate_public_headers.pypassed using the bundled Python runtime.python scripts/generate_public_headers.py --output-dir build/generated-check/include --source-output build/generated-check/runtime_dispatch.cc --devices cpu nvidia iluvatar hygon metax moore cambricon ascendpassed.Not Run
cmake -S . -B build -DWITH_CPU=ON -DINFINI_RT_BUILD_TESTING=ONbecausecmakeis not installed in this local environment.Risk
Low. This only removes public enum/string/list entries for backends that are not otherwise wired into the build or generated-header path.