Repository navigation
Conversation
If dx and the projector have the same number of OneTo axes but they are not identical, the sizes differ and the size check would throw anyway. Doing this check on types lets inference skip the type-unstable reshape, which returns a ReshapedArray for wrappers like Diagonal, UpperTriangular or Symmetric. Fixes #407 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 93.39% 93.40% +0.01%
==========================================
Files 15 15
Lines 999 1001 +2
==========================================
+ Hits 933 935 +2
Misses 66 66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407.
ProjectTo{AbstractArray}chooses betweendxandreshape(dx, project.axes)based on the values of the axes. For wrappers likeDiagonal,UpperTriangularorSymmetric,reshapereturns aReshapedArray, so the inferred result is aUnion:If
dxand the projector have the same number ofOneToaxes but they are not identical, the sizes differ and the size check throws anyway. This PR checks that case on types, so inference no longer sees thereshape. Behaviour is unchanged: the same inputs throw the same error, andreshapeis still used for trivial dimensions and OffsetArrays.ProjectTo(::AbstractArray)does not infer #407.Symmetricallocation test no longer needs to be marked broken.Note: #702 changes the same lines; whichever is merged second needs to add
!isempty(dx)to the new condition.🤖 Generated with Claude Code