Skip to content

Make ProjectTo{AbstractArray} inferrable for wrappers with OneTo axes #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devmotion wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −5
Open

Make ProjectTo{AbstractArray} inferrable for wrappers with OneTo axes #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d0eb4f
Make ProjectTo{AbstractArray} inferrable for wrappers with OneTo axes
devmotion Oct 16, 2026
a7e3338
Merge branch 'main' into dmw/triangular-projectto-inference
devmotion Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/projection.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ function (project::ProjectTo{AbstractArray})(dx::AbstractArray{S,M}) where {S,M}
# like dx = ones(4,1), where x = ones(4), but throw an error on dx = ones(1,4) etc.
dy = if axes(dx) === project.axes
dx
elseif project.axes isa Tuple{Vararg{Base.OneTo}} && axes(dx) isa typeof(project.axes)
# Same number of `OneTo` axes that are not identical: the sizes differ. Resolved from
# the types alone, so inference does not see the type-unstable `reshape` below.
throw(_projection_mismatch(project.axes, size(dx)))
else
for d in 1:max(M, length(project.axes))
if size(dx, d) != length(get(project.axes, d, 1))
Expand Down
15 changes: 10 additions & 5 deletions test/projection.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,11 +457,16 @@ struct NoSuperType end
@test 0 == @ballocated $pdiag(dx) setup = (dx = Diagonal(rand(10^3)))

psymm = ProjectTo(Symmetric(rand(10^3, 10^3)))
# The Union{Symmetric{…,Matrix}, Symmetric{…,ReshapedArray}} return value is only
# unboxed since JuliaLang/julia#55045 (sret_union ABI for types containing pointers)
@test 0 == @ballocated($psymm(dx), setup = (dx = Symmetric(rand(10^3, 10^3)))) broken = (
VERSION < v"1.14.0-DEV.1348"
)
@test 0 == @ballocated $psymm(dx) setup = (dx = Symmetric(rand(10^3, 10^3)))
end

@testset "#407" begin
@test @inferred(ProjectTo(rand(3, 3))(Diagonal(rand(3)))) isa Diagonal{Float64}
pupp = ProjectTo(UpperTriangular(rand(3, 3)))
@test @inferred(pupp(UpperTriangular(rand(3, 3)))) isa UpperTriangular{Float64}
psymm = ProjectTo(Symmetric(rand(3, 3)))
@test @inferred(psymm(Symmetric(rand(3, 3)))) isa Symmetric{Float64}
@test_throws DimensionMismatch ProjectTo(rand(3, 3))(Diagonal(rand(2)))
end

@testset "#685" begin
Expand Down
Loading