Repository navigation
feat(gcp): retain checked catalog commitment currency - #412
Conversation
Copy the checked pricing currency beside known commitment amounts. Leave failed or incomplete catalog prices unknown and keep savings currency separate. Pin the published shared contract for standalone use. Closes #411
cristim
added
priority/p2
|
Warning Review limit reached
This review includes 10 billable files and costs up to $2.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 7 minutes for your next included review. View limit details
Comment |
|
Independent cold verification: TWO retained adversarial passes, no actionable findings at exact head The independent verifier traced catalog validation and all three actual public The independent fixtures fail on the exact parent producers at intended runtime currency assertions, with only the published dependency overlaid so the new field compiles. A separate scratch mutation fabricating USD also fails all three services; restored sources pass and match the reviewed commit. Full standalone GCP race suite, build and pinned golangci-lint2.10.1 pass with ambient credentials disabled. Normal author hooks also pass. Evidence is synthetic SDK/catalog fixture data exercising actual production and published common code on macOS. No live cloud economics or account acceptance is claimed. Savings/baseline currency and platform compatibility/persistence are separate work under #124. The shared allocator migration must be adopted properly before platform pins advance. Cold receipt SHA256: |
|
Final merge gate at reviewed head 09730be: required CI and pre-commit succeeded, merge state CLEAN/MERGEABLE, no review threads, exact independent two-pass verdict and local producer verification recorded above. CR waived: quota, adversarial review + local verification + green CI. No manual quota retry or bypass. This ships a standalone GCP producer; platform dependency adoption remains separate under #124. |
|
Merged normally in #412 at Published GCP module A clean external module initially requiring only that GCP version naturally selected shared pkg Main pre-commit run38716233126 passed; main build/test run38716233119 remains watched. Fixture/library evidence proves the published producer contract, not live cloud prices or platform adoption. Remaining currency/platform work stays under #124. No new GCP follow-up issues surfaced beyond existing #399, #406 and #407. |
|
Final post-merge result: main build/test run38716233119 completed successfully at c2a461a, and main pre-commit run38716233126 also passed. Published GCP producer and natural dependency consumer verification passed as recorded above. Merged worktree and both feature refs have been cleaned up. This GCP producer leaf is complete; platform adoption remains separate under #124. |
1 participant
Fresh Compute Engine, Cloud SQL and Memorystore recommendations now retain
CommitmentCurrencyfrom the checked billing catalog beside their known commitment amounts. Catalog failures, missing/mixed currencies and unusable SQL/Redis prices keep the field unknown. Recommender savings currency remains separate.Pin the GCP module's minimum shared package to the published contract from #410 so standalone consumers receive the field without workspace replacements. The amount, scorer and offering behavior from #408 is unchanged.
Validation: Go 1.26.9 standalone GCP race suite and build, golangci-lint 2.10.1, and normal commit hooks pass. New fixture assertions compile and fail on the parent producer code, then pass after the assignments. EUR catalog prices with JPY Recommender savings yield EUR commitment currency; invalid catalog and scaling paths are covered. An owned scratch USD-default mutation fails all three services' EUR assertions. These are injected SDK fixtures, not live cloud acceptance.
Closes #411
Refs #124