Repository navigation
fix(purchase): isolate manual cleanup failures per plan - #871
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Exact reviewed head: Fresh independent verification completed two clean adversarial passes on this exact corrective diff. It independently reproduced the regression failure against parent production source, then passed the corrected full purchase race suite in35.245s, native manual/five-SP compatibility in9.795s, full build and pinned integration lint with zero issues. The uncertain failed manual plan is skipped, the later automatic plan reaches the actual notification/token/rotation/stamp path and counts one successful notice, and global configuration/list errors remain fatal. The regression uses mocked store failure and email delivery. Native compatibility uses real local PostgreSQL/store/resolver with fixture recommendation/source boundaries and no cloud execution. Author race34.922s/build/lint0 and ALL normal commit hooks passed. Retained independent source and exact staged-tree reviews each completed two clean passes. Owner explicitly approved publication of this exact payload/destination. Live head and target branch were verified after creation; labels match #631. The existing build/test CI was explicitly dispatched because feature-target PRs do not trigger the main/develop branch-filtered workflows automatically. Run Review follows the owner's explicit independent Sol review direction. No CodeRabbit quota wait is required under that path, but every actual new finding remains subject to verification and disposition. No real purchase, cloud mutation or manual deployment is authorized by these results. |
|
Merged normally into #870's feature branch as The resulting tree exactly equals reviewed corrective tree This is a feature-branch integration receipt, not a deployment or live purchase test. Source refs and verification artifacts are preserved for the remaining #631 work. No separate follow-up issue was filed: the umbrella #631 and #870 explicitly retain the unfinished main merge and remaining feature work. |
* fix(purchase): attach recommendations to explicit manual plan steps Allow enabled manual plans to attach and notify explicit scheduled roots while automatic purchasing is disabled. Preserve automatic mode guards and optional manual commitment caps. Fail due empty manual roots without requiring an email recipient or overdue grace eligibility, pinning the empty recommendation snapshot so concurrent attachment cannot be overwritten. Refs #631 * fix(ci): bound integration package runtime at twenty minutes * fix(purchase): isolate manual cleanup failures per plan (#871)
One manual-plan cleanup transaction error currently aborts the entire notification tick, preventing later automatic plans from receiving their notices. Log that failure and skip the uncertain plan so the remaining plans continue. Global configuration and plan-list failures still stop the tick.
Follow-up to #870 and verified review finding4275415396. Refs #631. This PR targets #870's feature branch so the correction lands before the final main merge; it changes only two files,40 lines.
Validation at
60167762a1ed6cf4b78b2426b0f7426a07b0277a: retained independent source/staged two-pass reviews clean; the new regression fails on the unchanged parent and passes after correction; author full purchase race34.922s, build, pinned integration lint0 and all normal hooks passed. The regression uses simulated store failures and email delivery while exercising the actual notification loop and token-generation path. Fresh cold verification and explicit full CI workflow dispatch are required before merge.The existing workflow branch filters do not trigger automatic checks for a feature-target PR. CI - Build & Test will be explicitly dispatched on this exact branch and watched through full success; the pre-commit workflow has no manual trigger, so Linux pre-commit is not claimed. All local normal commit hooks passed. Final #870 must independently regain every normal main-target check on its new exact head. No real purchases, cloud mutations, graph/UI changes or deployment commands.