Repository navigation
🧭 feat: Add Guided Worker Setup And Saved Profiles - #339
lia-by-librechat[bot] wants to merge 3 commits into
Conversation
|
Review head: acde365. Adds guided CLI pairing/access selection, separate private profiles, profile-aware startup, and regression coverage. Browser approval is a follow-up; existing pairing remains supported. |
|
Review head: a514ea7. Independent review of acde365 found one P2: hidden pairing codes could be recalled visibly from readline history. Fixed in a514ea7 by disabling history. Added terminal-mode Up/Ctrl-P regression coverage, reproduced failing before the fix and passing afterward. Build/typecheck passed; 64 focused onboarding tests passed with the previously disclosed storage-metadata fixture. New-head independent review and CI are running. Browser/OAuth approval remains outside this CLI-foundation PR. |
|
Review head: 3fd0d5d. Finding ledger: 339-R1 (P2, readline history) fixed in a514ea7; 339-R2 (P2, retained secret editing/kill buffer) fixed in 3fd0d5d. After the second actionable round, swept the prompt lifecycle by invariant: every prompt now owns a disposable readline instance, closed before output is unmuted. History and kill/yank regressions pass; 67 focused onboarding tests and build/no-emit typecheck pass. Fresh exact-head independent review and CI are running. The prior head had an API input-cache assertion failure in unchanged code; the new head has a new CI run. |
|
Independent review completed for 3fd0d5d: no findings. Both prior P2s are verified fixed; none rejected. Build/no-emit typecheck, 67 focused onboarding tests (with the disclosed storage fixture), four fixture-free terminal editing regressions, real-terminal acceptance/cancellation, and inspector state checks passed. Browser/OAuth approval is still outstanding. |
|
@codex review the latest head, final review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
CLI foundation for simpler machine onboarding. Owners currently pair separately, assemble startup flags, and repeat configuration on every restart.
librechat-code setup: workspace/access choices, hidden pairing-code entry, confirmation, and sandbox dependency checks before redemption.runloads it when no legacy configuration exists;run --profile <file>selects another.--code-stdin. Preserve existingpairand environment-variable startup.This is not all of slice 1. It uses current LibreChat one-time pairing. Browser/OAuth approval sessions remain outstanding. Startup recovery is separate in #341; diagnostics/service/lifecycle UI remain follow-ups.
Verification
npx --no-install tsc --noEmitpassed on Node 24.16.0./,/tmp, and/homeas UID 65534.Review
Current head:
3fd0d5dffc8f701f6f17694b07691f022174b51d.Independent review found two P2s: readline history retained the secret (fixed in
a514ea7), then the kill buffer retained secret editing state (fixed in3fd0d5d). Swept the lifecycle by invariant: prompts use disposable readline instances. Independent review of3fd0d5dcompleted with no findings. Both P2s are verified fixed; no findings were rejected. Current-head CI has no failures; the Lambda MicroVM image check is still pending.